mchades commented on code in PR #14609:
URL: https://github.com/apache/gravitino/pull/14609#discussion_r4465248930


##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/SparkTableChangeConverter.java:
##########
@@ -93,13 +99,37 @@ public org.apache.gravitino.rel.TableChange 
toGravitinoTableChange(TableChange c
           (TableChange.UpdateColumnDefaultValue) change;
       return org.apache.gravitino.rel.TableChange.updateColumnDefaultValue(
           updateColumnDefaultValue.fieldNames(),
-          Literals.stringLiteral(updateColumnDefaultValue.newDefaultValue()));
+          convertDefaultValue(updateColumnDefaultValue.newDefaultValue()));
     } else {
       throw new UnsupportedOperationException(
           String.format("Unsupported table change %s", 
change.getClass().getName()));
     }
   }
 
+  private Expression convertDefaultValue(String sql) {
+    // Spark uses an empty SQL string for DROP DEFAULT; a string literal 
containing no characters
+    // is represented by two quote characters instead.
+    if (sql.isEmpty()) {
+      return Column.DEFAULT_VALUE_NOT_SET;
+    }
+    try {
+      org.apache.spark.sql.catalyst.expressions.Expression parsed =
+          CatalystSqlParser$.MODULE$.parseExpression(sql);
+      boolean literal =
+          parsed instanceof Literal
+              || (parsed instanceof UnaryMinus && ((UnaryMinus) 
parsed).child() instanceof Literal);
+      Preconditions.checkArgument(
+          literal && parsed.resolved() && parsed.foldable(),
+          "Only literal column defaults are supported: %s",
+          sql);
+      Object value = parsed.eval(null);
+      return SparkPartitionUtils.toGravitinoLiteral(

Review Comment:
   [P2] Please cover timestamp and binary literals before delegating to this 
partition-specific helper. `TIMESTAMP '2026-11-04 12:34:56'`, `TIMESTAMP_NTZ 
'2026-11-04 12:34:56.123456'`, and `X'4142'` pass the literal checks above, but 
`toGravitinoLiteral` has no branches for `TimestampType`, `TimestampNTZType`, 
or `BinaryType`, so these valid defaults all throw. Gravitino already 
represents these types. Please add the corresponding conversions and regression 
tests; reproduced on Spark 3.5 and 4.0.



##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/SparkTableChangeConverter.java:
##########
@@ -93,13 +99,37 @@ public org.apache.gravitino.rel.TableChange 
toGravitinoTableChange(TableChange c
           (TableChange.UpdateColumnDefaultValue) change;
       return org.apache.gravitino.rel.TableChange.updateColumnDefaultValue(
           updateColumnDefaultValue.fieldNames(),
-          Literals.stringLiteral(updateColumnDefaultValue.newDefaultValue()));
+          convertDefaultValue(updateColumnDefaultValue.newDefaultValue()));
     } else {
       throw new UnsupportedOperationException(
           String.format("Unsupported table change %s", 
change.getClass().getName()));
     }
   }
 
+  private Expression convertDefaultValue(String sql) {
+    // Spark uses an empty SQL string for DROP DEFAULT; a string literal 
containing no characters
+    // is represented by two quote characters instead.
+    if (sql.isEmpty()) {
+      return Column.DEFAULT_VALUE_NOT_SET;
+    }
+    try {
+      org.apache.spark.sql.catalyst.expressions.Expression parsed =
+          CatalystSqlParser$.MODULE$.parseExpression(sql);
+      boolean literal =
+          parsed instanceof Literal
+              || (parsed instanceof UnaryMinus && ((UnaryMinus) 
parsed).child() instanceof Literal);

Review Comment:
   [P2] Please also accept `UnaryPositive` with a literal child. Spark parses 
`+42` as `UnaryPositive(Literal(42))`, so `SET DEFAULT +42` is rejected here 
even though `42` and `-42` are accepted. Handle the positive sign consistently 
with the negative sign and add a `+42` test. Reproduced on Spark 3.5 and 4.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to