yuqi1129 opened a new pull request, #14641:
URL: https://github.com/apache/gravitino/pull/14641

   ### What changes were proposed in this pull request?
   
   - Keep a bounded, NUL-free entity-store projection of source column comments 
while returning the complete source comment and preserving column IDs. Reject 
NUL request comments before source DDL.
   - Lock the target catalog during catalog creation and the target table 
during DROP. Run orphaned-schema cleanup under its schema lock after releasing 
the table lock; retain managed-table behavior.
   - Apply provider existing-name rules to existing column references, while 
preserving strict add/rename-target rules. Enable PostgreSQL's existing-name 
specification for columns.
   
   ### Why are the changes needed?
   
   External column comments containing NUL or exceeding entity-store capacity 
make otherwise valid tables unloadable. User writes can execute source DDL 
before a NUL comment fails registration. Catalog creation holds a metalake 
write lock during source verification, while table DROP holds a schema write 
lock during source DDL, blocking unrelated objects. Existing native column 
references also use creation-name rules even when a provider safely supports 
them.
   
   Fixes #14640
   
   ### Does this PR introduce _any_ user-facing change?
   
   External column comments remain complete in returned source metadata; their 
stored projection is capped at 4096 UTF-16 units. No storage migration is 
required. Source DDL/verification no longer holds the former ancestor write 
lock. This adds no SQL timeout or cancellation, and cold table import retains 
its existing locking behavior (separately addressed by PR #14508). Providers 
other than PostgreSQL retain their existing-name defaults until they opt in. 
Cross-node source/store atomicity is unchanged.
   
   ### How was this patch tested?
   
   144 cases passed with zero failures/errors/skips: 132 core cases across 
catalog creation, table operations, normalization, capabilities, and column 
entities; 12 PostgreSQL capability cases. New regressions exercise long/NUL 
source comment import and subsequent update with full response comments and 
stable IDs, rejected NUL CREATE/ALTER requests, sibling catalog creation, and 
actual blocked source DROP with concurrent warm sibling load/list. Scoped 
Spotless and git diff checks passed. The comment projection was tested with the 
in-memory entity store, not a live relational-store deployment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to