jerryshao commented on issue #13317:
URL: https://github.com/apache/gravitino/issues/13317#issuecomment-6758808778

   Status check against current `main`:
   
   - **Items 3 and 6** are done in #14636 (view 
`default_catalog`/`default_schema` and the metalake creator name are validated 
before anything is created).
   - **Item 2** needs no change. As @mchades noted, the external system is the 
source of truth on these paths and the entity store update is intentionally 
best effort.
   - **Item 1** still applies. `TopicOperationDispatcher#importTopic` wraps a 
failed `store.put` in a `RuntimeException`, so loading a Kafka topic with a 
name longer than 128 characters returns 500. `topic_meta.topic_name` is 
`VARCHAR(128)` in all backends while Kafka allows 249. Proposal: validate the 
name during import and return a clear client error; widening the column would 
be the full fix but needs an upgrade script.
   - **Item 4** still applies. In the 2.0.0 schemas `storage_location_name` and 
`model_version_uri_name` are `VARCHAR(128)` in H2 but `VARCHAR(256)` in MySQL 
and PostgreSQL. Aligning them needs an upgrade script, then `EntityFieldLimits` 
checks.
   - **Item 5** is low priority and can go together with item 4.
   
   Remaining work is items 1, 4 and 5. Item 1 is a good candidate for a 
separate small PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to