Repository: incubator-griffin
Updated Branches:
refs/heads/master c7a7c670b -> bd911ea91
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("...").s()
Author: Eugene <[email protected]>
Closes #336 from toyboxman/b2.
Project: http://git-wip-us.apache.org/repos/asf/incubator-griffin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-griffin/commit/bd911ea9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-griffin/tree/bd911ea9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-griffin/diff/bd911ea9
Branch: refs/heads/master
Commit: bd911ea9198a4f8110c9a4381486842ec27317d2
Parents: c7a7c67
Author: Eugene <[email protected]>
Authored: Thu Jul 5 15:02:43 2018 +0800
Committer: Lionel Liu <[email protected]>
Committed: Thu Jul 5 15:02:43 2018 +0800
----------------------------------------------------------------------
.../apache/griffin/measure/step/builder/dsl/expr/SelectExpr.scala | 2 +-
.../step/builder/dsl/transform/analyzer/CompletenessAnalyzer.scala | 2 +-
.../step/builder/dsl/transform/analyzer/DistinctnessAnalyzer.scala | 2 +-
.../step/builder/dsl/transform/analyzer/TimelinessAnalyzer.scala | 2 +-
.../step/builder/dsl/transform/analyzer/UniquenessAnalyzer.scala | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-griffin/blob/bd911ea9/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/SelectExpr.scala
----------------------------------------------------------------------
diff --git
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/SelectExpr.scala
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/SelectExpr.scala
index b4ed2ac..b64dae2 100644
---
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/SelectExpr.scala
+++
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/SelectExpr.scala
@@ -57,7 +57,7 @@ trait SelectExpr extends Expr with AliasableExpr {
}
case class AllFieldsSelectExpr() extends SelectExpr {
- def desc: String = s".*"
+ def desc: String = ".*"
def coalesceDesc: String = desc
def alias: Option[String] = None
}
http://git-wip-us.apache.org/repos/asf/incubator-griffin/blob/bd911ea9/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/CompletenessAnalyzer.scala
----------------------------------------------------------------------
diff --git
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/CompletenessAnalyzer.scala
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/CompletenessAnalyzer.scala
index eab568c..f8b872a 100644
---
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/CompletenessAnalyzer.scala
+++
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/CompletenessAnalyzer.scala
@@ -40,7 +40,7 @@ case class CompletenessAnalyzer(expr: CompletenessClause,
sourceName: String) ex
}
if (selectionPairs.isEmpty) {
- throw new Exception(s"completeness analyzer error: empty selection")
+ throw new Exception("completeness analyzer error: empty selection")
}
}
http://git-wip-us.apache.org/repos/asf/incubator-griffin/blob/bd911ea9/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/DistinctnessAnalyzer.scala
----------------------------------------------------------------------
diff --git
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/DistinctnessAnalyzer.scala
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/DistinctnessAnalyzer.scala
index efa1754..9cee8ab 100644
---
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/DistinctnessAnalyzer.scala
+++
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/DistinctnessAnalyzer.scala
@@ -41,7 +41,7 @@ case class DistinctnessAnalyzer(expr: DistinctnessClause,
sourceName: String) ex
}
if (selectionPairs.isEmpty) {
- throw new Exception(s"uniqueness analyzer error: empty selection")
+ throw new Exception("uniqueness analyzer error: empty selection")
}
}
http://git-wip-us.apache.org/repos/asf/incubator-griffin/blob/bd911ea9/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/TimelinessAnalyzer.scala
----------------------------------------------------------------------
diff --git
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/TimelinessAnalyzer.scala
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/TimelinessAnalyzer.scala
index af00080..6fa8eef 100644
---
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/TimelinessAnalyzer.scala
+++
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/TimelinessAnalyzer.scala
@@ -57,7 +57,7 @@ case class TimelinessAnalyzer(expr: TimelinessClause,
sourceName: String) extend
private val exprs = expr.exprs.map(_.desc).toList
val (btsExpr, etsExprOpt) = exprs match {
- case Nil => throw new Exception(s"timeliness analyzer error: ts column not
set")
+ case Nil => throw new Exception("timeliness analyzer error: ts column not
set")
case btsExpr :: Nil => (btsExpr, None)
case btsExpr :: etsExpr :: _ => (btsExpr, Some(etsExpr))
}
http://git-wip-us.apache.org/repos/asf/incubator-griffin/blob/bd911ea9/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/UniquenessAnalyzer.scala
----------------------------------------------------------------------
diff --git
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/UniquenessAnalyzer.scala
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/UniquenessAnalyzer.scala
index 21a1628..0976d6c 100644
---
a/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/UniquenessAnalyzer.scala
+++
b/measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/analyzer/UniquenessAnalyzer.scala
@@ -40,7 +40,7 @@ case class UniquenessAnalyzer(expr: UniquenessClause,
sourceName: String, target
}
if (selectionPairs.isEmpty) {
- throw new Exception(s"uniqueness analyzer error: empty selection")
+ throw new Exception("uniqueness analyzer error: empty selection")
}
}
