remove checkstyle warnings
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/3c7c8748 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/3c7c8748 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/3c7c8748 Branch: refs/heads/parrot Commit: 3c7c8748a3e2d346a600f87a1941e1de49f8b15e Parents: 0d5c0b8 Author: paulk <pa...@asert.com.au> Authored: Thu Dec 29 22:30:38 2016 +1000 Committer: paulk <pa...@asert.com.au> Committed: Thu Dec 29 22:30:38 2016 +1000 ---------------------------------------------------------------------- src/main/groovy/lang/GroovyClassLoader.java | 2 +- src/main/groovy/lang/ObjectRange.java | 2 +- src/main/groovy/ui/GroovyMain.java | 6 +++--- src/main/groovy/ui/GroovySocketServer.java | 4 ++-- src/main/groovy/util/ConfigObject.java | 2 +- src/main/org/apache/groovy/metaclass/Realm.java | 2 +- src/main/org/codehaus/groovy/GroovyBugError.java | 2 +- .../codehaus/groovy/ast/decompiled/AsmDecompiler.java | 4 ++-- .../codehaus/groovy/classgen/FinalVariableAnalyzer.java | 2 +- src/main/org/codehaus/groovy/classgen/Verifier.java | 2 +- .../org/codehaus/groovy/classgen/asm/MopWriter.java | 7 ++++--- .../org/codehaus/groovy/classgen/asm/OperandStack.java | 3 ++- .../classgen/asm/sc/StaticTypesClosureWriter.java | 2 +- .../classgen/asm/sc/StaticTypesWriterController.java | 2 +- .../groovy/control/ASTTransformationsContext.java | 1 - .../org/codehaus/groovy/control/StaticVerifier.java | 3 ++- .../groovy/control/customizers/ImportCustomizer.java | 2 +- .../groovy/control/customizers/SecureASTCustomizer.java | 4 ++-- .../customizers/builder/ImportCustomizerFactory.java | 2 +- .../org/codehaus/groovy/reflection/CachedMethod.java | 4 ++-- src/main/org/codehaus/groovy/reflection/ClassInfo.java | 2 +- .../codehaus/groovy/reflection/GroovyClassValue.java | 2 +- .../groovy/reflection/GroovyClassValueFactory.java | 2 +- .../codehaus/groovy/runtime/DefaultGroovyMethods.java | 4 ++-- .../org/codehaus/groovy/runtime/IOGroovyMethods.java | 2 +- .../codehaus/groovy/runtime/ResourceGroovyMethods.java | 4 ++-- .../codehaus/groovy/runtime/SocketGroovyMethods.java | 4 ++-- .../codehaus/groovy/runtime/StringGroovyMethods.java | 12 ++++++------ .../groovy/runtime/metaclass/MetaMethodIndex.java | 4 ++-- .../groovy/transform/AbstractASTTransformation.java | 1 - .../groovy/transform/stc/StaticTypeCheckingSupport.java | 2 +- src/main/org/codehaus/groovy/util/ListHashMap.java | 7 ++++--- 32 files changed, 53 insertions(+), 51 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/groovy/lang/GroovyClassLoader.java ---------------------------------------------------------------------- diff --git a/src/main/groovy/lang/GroovyClassLoader.java b/src/main/groovy/lang/GroovyClassLoader.java index c75bb2f..11dedfd 100644 --- a/src/main/groovy/lang/GroovyClassLoader.java +++ b/src/main/groovy/lang/GroovyClassLoader.java @@ -987,7 +987,7 @@ public class GroovyClassLoader extends URLClassLoader { } private static class TimestampAdder extends CompilationUnit.PrimaryClassNodeOperation implements Opcodes { - private final static TimestampAdder INSTANCE = new TimestampAdder(); + private static final TimestampAdder INSTANCE = new TimestampAdder(); private TimestampAdder() {} http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/groovy/lang/ObjectRange.java ---------------------------------------------------------------------- diff --git a/src/main/groovy/lang/ObjectRange.java b/src/main/groovy/lang/ObjectRange.java index 1cf392e..a7e2b05 100644 --- a/src/main/groovy/lang/ObjectRange.java +++ b/src/main/groovy/lang/ObjectRange.java @@ -414,7 +414,7 @@ public class ObjectRange extends AbstractList<Comparable> implements Range<Compa /** * Non-thread-safe iterator which lazily produces the next element only on calls of hasNext() or next() */ - private static class StepIterator implements Iterator<Comparable> { + private static final class StepIterator implements Iterator<Comparable> { // actual step, can be +1 when desired step is -1 and direction is from high to low private final int step; private final ObjectRange range; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/groovy/ui/GroovyMain.java ---------------------------------------------------------------------- diff --git a/src/main/groovy/ui/GroovyMain.java b/src/main/groovy/ui/GroovyMain.java index 6f44e67..0fdd696 100644 --- a/src/main/groovy/ui/GroovyMain.java +++ b/src/main/groovy/ui/GroovyMain.java @@ -368,7 +368,7 @@ public class GroovyMain { */ @Deprecated public String getText(String uriOrFilename) throws IOException { - if (uriPattern.matcher(uriOrFilename).matches()) { + if (URI_PATTERN.matcher(uriOrFilename).matches()) { try { return ResourceGroovyMethods.getText(new URL(uriOrFilename)); } catch (Exception e) { @@ -394,7 +394,7 @@ public class GroovyMain { if (isScriptFile) { // search for the file and if it exists don't try to use URIs ... File scriptFile = huntForTheScriptFile(script); - if (!scriptFile.exists() && uriPattern.matcher(script).matches()) { + if (!scriptFile.exists() && URI_PATTERN.matcher(script).matches()) { return new GroovyCodeSource(new URI(script)); } return new GroovyCodeSource( scriptFile ); @@ -405,7 +405,7 @@ public class GroovyMain { // RFC2396 // scheme = alpha *( alpha | digit | "+" | "-" | "." ) // match URIs but not Windows filenames, e.g.: http://cnn.com but not C:\xxx\file.ext - private static final Pattern uriPattern = Pattern.compile("\\p{Alpha}[-+.\\p{Alnum}]*:[^\\\\]*"); + private static final Pattern URI_PATTERN = Pattern.compile("\\p{Alpha}[-+.\\p{Alnum}]*:[^\\\\]*"); /** * Search for the script file, doesn't bother if it is named precisely. http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/groovy/ui/GroovySocketServer.java ---------------------------------------------------------------------- diff --git a/src/main/groovy/ui/GroovySocketServer.java b/src/main/groovy/ui/GroovySocketServer.java index 891e5d8..e5460da 100644 --- a/src/main/groovy/ui/GroovySocketServer.java +++ b/src/main/groovy/ui/GroovySocketServer.java @@ -93,7 +93,7 @@ public class GroovySocketServer implements Runnable { private static GroovyCodeSource getCodeSource(boolean scriptFile, String scriptFilenameOrText) { if (scriptFile) { try { - if (uriPattern.matcher(scriptFilenameOrText).matches()) { + if (URI_PATTERN.matcher(scriptFilenameOrText).matches()) { return new GroovyCodeSource(new URI(scriptFilenameOrText)); } else { return new GroovyCodeSource(GroovyMain.searchForGroovyScriptFile(scriptFilenameOrText)); @@ -118,7 +118,7 @@ public class GroovySocketServer implements Runnable { // RFC2396 // scheme = alpha *( alpha | digit | "+" | "-" | "." ) - private static final Pattern uriPattern = Pattern.compile("\\p{Alpha}[-+.\\p{Alnum}]*:.*"); + private static final Pattern URI_PATTERN = Pattern.compile("\\p{Alpha}[-+.\\p{Alnum}]*:.*"); /** * This creates and starts the socket server on a new Thread. There is no need to call run or spawn http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/groovy/util/ConfigObject.java ---------------------------------------------------------------------- diff --git a/src/main/groovy/util/ConfigObject.java b/src/main/groovy/util/ConfigObject.java index 8452455..6308d74 100644 --- a/src/main/groovy/util/ConfigObject.java +++ b/src/main/groovy/util/ConfigObject.java @@ -53,7 +53,7 @@ public class ConfigObject extends GroovyObjectSupport implements Writable, Map, */ private URL configFile; - private LinkedHashMap delegateMap = new LinkedHashMap(); + private HashMap delegateMap = new LinkedHashMap(); public ConfigObject(URL file) { this.configFile = file; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/apache/groovy/metaclass/Realm.java ---------------------------------------------------------------------- diff --git a/src/main/org/apache/groovy/metaclass/Realm.java b/src/main/org/apache/groovy/metaclass/Realm.java index d398c1c..a652dab 100644 --- a/src/main/org/apache/groovy/metaclass/Realm.java +++ b/src/main/org/apache/groovy/metaclass/Realm.java @@ -33,7 +33,7 @@ import java.util.Objects; */ @Incubating public final class Realm { - private final static Realm ROOT = new Realm("ROOT", null); + private static final Realm ROOT = new Realm("ROOT", null); private final String name; private final Realm parent; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/GroovyBugError.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/GroovyBugError.java b/src/main/org/codehaus/groovy/GroovyBugError.java index 040c137..30ed7de 100644 --- a/src/main/org/codehaus/groovy/GroovyBugError.java +++ b/src/main/org/codehaus/groovy/GroovyBugError.java @@ -21,7 +21,7 @@ package org.codehaus.groovy; /** * This class represents an error that is thrown when a bug is * recognized inside the runtime. Basically it is thrown when - * a constraint is not fullfilled that should be fullfiled. + * a constraint is not fulfilled that should be fulfilled. * * @author Jochen Theodorou */ http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/ast/decompiled/AsmDecompiler.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/ast/decompiled/AsmDecompiler.java b/src/main/org/codehaus/groovy/ast/decompiled/AsmDecompiler.java index 32e5313..e17847a 100644 --- a/src/main/org/codehaus/groovy/ast/decompiled/AsmDecompiler.java +++ b/src/main/org/codehaus/groovy/ast/decompiled/AsmDecompiler.java @@ -157,7 +157,7 @@ public abstract class AsmDecompiler { return name.replace('/', '.'); } - private static abstract class AnnotationReader extends AnnotationVisitor { + private abstract static class AnnotationReader extends AnnotationVisitor { public AnnotationReader() { super(Opcodes.ASM5); } @@ -183,7 +183,7 @@ public abstract class AsmDecompiler { @Override public AnnotationVisitor visitArray(String name) { - final ArrayList<Object> list = new ArrayList<Object>(); + final List<Object> list = new ArrayList<Object>(); visitAttribute(name, list); return new AnnotationReader() { @Override http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/classgen/FinalVariableAnalyzer.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/classgen/FinalVariableAnalyzer.java b/src/main/org/codehaus/groovy/classgen/FinalVariableAnalyzer.java index dc47387..8983489 100644 --- a/src/main/org/codehaus/groovy/classgen/FinalVariableAnalyzer.java +++ b/src/main/org/codehaus/groovy/classgen/FinalVariableAnalyzer.java @@ -332,7 +332,7 @@ public class FinalVariableAnalyzer extends ClassCodeVisitorSupport { } } - public static interface VariableNotFinalCallback { + public interface VariableNotFinalCallback { /** * Callback called whenever an assignment transforms an effectively final variable into a non final variable * (aka, breaks the "final" modifier contract) http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/classgen/Verifier.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/classgen/Verifier.java b/src/main/org/codehaus/groovy/classgen/Verifier.java index 382c9a2..9f90dd0 100644 --- a/src/main/org/codehaus/groovy/classgen/Verifier.java +++ b/src/main/org/codehaus/groovy/classgen/Verifier.java @@ -263,7 +263,7 @@ public class Verifier implements GroovyClassVisitor, Opcodes { } private static void checkForDuplicateMethods(ClassNode cn) { - HashSet<String> descriptors = new HashSet<String>(); + Set<String> descriptors = new HashSet<String>(); for (MethodNode mn : cn.getMethods()) { if (mn.isSynthetic()) continue; String mySig = makeDescriptorWithoutReturnType(mn); http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/classgen/asm/MopWriter.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/classgen/asm/MopWriter.java b/src/main/org/codehaus/groovy/classgen/asm/MopWriter.java index af65c9d..416ce07 100644 --- a/src/main/org/codehaus/groovy/classgen/asm/MopWriter.java +++ b/src/main/org/codehaus/groovy/classgen/asm/MopWriter.java @@ -24,6 +24,7 @@ import java.util.HashMap; import java.util.HashSet; import java.util.LinkedList; import java.util.List; +import java.util.Map; import java.util.Set; import org.codehaus.groovy.ast.ClassHelper; @@ -35,7 +36,7 @@ import org.objectweb.asm.MethodVisitor; import static org.objectweb.asm.Opcodes.*; public class MopWriter { - public static interface Factory { + public interface Factory { MopWriter create(WriterController controller); } @@ -85,7 +86,7 @@ public class MopWriter { private static Set<MopKey> buildCurrentClassSignatureSet(List<MethodNode> methods) { if (methods.isEmpty()) return Collections.EMPTY_SET; - HashSet<MopKey> result = new HashSet<MopKey>(methods.size()); + Set<MopKey> result = new HashSet<MopKey>(methods.size()); for (MethodNode mn : methods) { MopKey key = new MopKey(mn.getName(), mn.getParameters()); result.add(key); @@ -105,7 +106,7 @@ public class MopWriter { * @see #generateMopCalls(LinkedList, boolean) */ private void visitMopMethodList(List<MethodNode> methods, boolean isThis, Set<MopKey> useOnlyIfDeclaredHereToo, List<String> orNameMentionedHere) { - HashMap<MopKey, MethodNode> mops = new HashMap<MopKey, MethodNode>(); + Map<MopKey, MethodNode> mops = new HashMap<MopKey, MethodNode>(); LinkedList<MethodNode> mopCalls = new LinkedList<MethodNode>(); for (MethodNode mn : methods) { // mop methods are helper for this and super calls and do direct calls http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/classgen/asm/OperandStack.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/classgen/asm/OperandStack.java b/src/main/org/codehaus/groovy/classgen/asm/OperandStack.java index e9c8652..3be622b 100644 --- a/src/main/org/codehaus/groovy/classgen/asm/OperandStack.java +++ b/src/main/org/codehaus/groovy/classgen/asm/OperandStack.java @@ -21,6 +21,7 @@ package org.codehaus.groovy.classgen.asm; import java.math.BigDecimal; import java.math.BigInteger; import java.util.ArrayList; +import java.util.List; import org.codehaus.groovy.GroovyBugError; import org.codehaus.groovy.ast.*; @@ -37,7 +38,7 @@ import static org.objectweb.asm.Opcodes.*; public class OperandStack { private final WriterController controller; - private final ArrayList<ClassNode> stack = new ArrayList<ClassNode>(); + private final List<ClassNode> stack = new ArrayList<ClassNode>(); public OperandStack(WriterController wc) { this.controller = wc; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesClosureWriter.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesClosureWriter.java b/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesClosureWriter.java index 48e3d87..fc26486 100644 --- a/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesClosureWriter.java +++ b/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesClosureWriter.java @@ -110,7 +110,7 @@ public class StaticTypesClosureWriter extends ClosureWriter { new ReturnStatement(doCallNoArgs))); } - private static class MethodTargetCompletionVisitor extends ClassCodeVisitorSupport { + private static final class MethodTargetCompletionVisitor extends ClassCodeVisitorSupport { private final MethodNode doCallMethod; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesWriterController.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesWriterController.java b/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesWriterController.java index e8c84cc..577676f 100644 --- a/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesWriterController.java +++ b/src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesWriterController.java @@ -40,7 +40,7 @@ import java.lang.reflect.Constructor; */ public class StaticTypesWriterController extends DelegatingController { - private final static Constructor indyBinHelper; + private static final Constructor indyBinHelper; static { Constructor ctor = null; try { http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/control/ASTTransformationsContext.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/control/ASTTransformationsContext.java b/src/main/org/codehaus/groovy/control/ASTTransformationsContext.java index 9cc0b10..ae95275 100644 --- a/src/main/org/codehaus/groovy/control/ASTTransformationsContext.java +++ b/src/main/org/codehaus/groovy/control/ASTTransformationsContext.java @@ -19,7 +19,6 @@ package org.codehaus.groovy.control; import groovy.lang.GroovyClassLoader; -import org.codehaus.groovy.control.CompilationUnit; import java.util.HashSet; import java.util.Set; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/control/StaticVerifier.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/control/StaticVerifier.java b/src/main/org/codehaus/groovy/control/StaticVerifier.java index 166f1b5..a1e6c1e 100644 --- a/src/main/org/codehaus/groovy/control/StaticVerifier.java +++ b/src/main/org/codehaus/groovy/control/StaticVerifier.java @@ -37,6 +37,7 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.HashSet; import java.util.List; +import java.util.Set; import static org.codehaus.groovy.ast.tools.ClassNodeUtils.isInnerClass; @@ -85,7 +86,7 @@ public class StaticVerifier extends ClassCodeVisitorSupport { currentMethod = node; super.visitConstructorOrMethod(node, isConstructor); if (isConstructor) { - final HashSet<String> exceptions = new HashSet<String>(); + final Set<String> exceptions = new HashSet<String>(); for (final Parameter param : node.getParameters()) { exceptions.add(param.getName()); if (param.hasInitialExpression()) { http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/control/customizers/ImportCustomizer.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/control/customizers/ImportCustomizer.java b/src/main/org/codehaus/groovy/control/customizers/ImportCustomizer.java index 8d5cd91..a1069c0 100644 --- a/src/main/org/codehaus/groovy/control/customizers/ImportCustomizer.java +++ b/src/main/org/codehaus/groovy/control/customizers/ImportCustomizer.java @@ -127,7 +127,7 @@ public class ImportCustomizer extends CompilationCustomizer { /** * Represents imports which are possibly aliased. */ - private static class Import { + private static final class Import { final ImportType type; final ClassNode classNode; final String alias; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/control/customizers/SecureASTCustomizer.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/control/customizers/SecureASTCustomizer.java b/src/main/org/codehaus/groovy/control/customizers/SecureASTCustomizer.java index a05d899..b3d39f7 100644 --- a/src/main/org/codehaus/groovy/control/customizers/SecureASTCustomizer.java +++ b/src/main/org/codehaus/groovy/control/customizers/SecureASTCustomizer.java @@ -1107,7 +1107,7 @@ public class SecureASTCustomizer extends CompilationCustomizer { * This interface allows the user to plugin custom expression checkers if expression blacklist or whitelist are not * sufficient */ - public static interface ExpressionChecker { + public interface ExpressionChecker { boolean isAuthorized(Expression expression); } @@ -1115,7 +1115,7 @@ public class SecureASTCustomizer extends CompilationCustomizer { * This interface allows the user to plugin custom statement checkers if statement blacklist or whitelist are not * sufficient */ - public static interface StatementChecker { + public interface StatementChecker { boolean isAuthorized(Statement expression); } http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/control/customizers/builder/ImportCustomizerFactory.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/control/customizers/builder/ImportCustomizerFactory.java b/src/main/org/codehaus/groovy/control/customizers/builder/ImportCustomizerFactory.java index 4f129fe..e9e8b7e 100644 --- a/src/main/org/codehaus/groovy/control/customizers/builder/ImportCustomizerFactory.java +++ b/src/main/org/codehaus/groovy/control/customizers/builder/ImportCustomizerFactory.java @@ -86,7 +86,7 @@ public class ImportCustomizerFactory extends AbstractFactory { return false; } - private static class ImportHelper { + private static final class ImportHelper { private final ImportCustomizer customizer; private ImportHelper(final ImportCustomizer customizer) { http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/reflection/CachedMethod.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/reflection/CachedMethod.java b/src/main/org/codehaus/groovy/reflection/CachedMethod.java index a482ebc..8c1c4a0 100644 --- a/src/main/org/codehaus/groovy/reflection/CachedMethod.java +++ b/src/main/org/codehaus/groovy/reflection/CachedMethod.java @@ -42,7 +42,7 @@ public class CachedMethod extends MetaMethod implements Comparable { private final Method cachedMethod; private int hashCode; - private static final MyComparator comparator = new MyComparator(); + private static final MyComparator COMPARATOR = new MyComparator(); private SoftReference<Constructor> pogoCallSiteConstructor, pojoCallSiteConstructor, staticCallSiteConstructor; @@ -65,7 +65,7 @@ public class CachedMethod extends MetaMethod implements Comparable { // return cachedMethod; // } // return null; - int i = Arrays.binarySearch(methods, method, comparator); + int i = Arrays.binarySearch(methods, method, COMPARATOR); if (i < 0) return null; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/reflection/ClassInfo.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/reflection/ClassInfo.java b/src/main/org/codehaus/groovy/reflection/ClassInfo.java index 57956af..b240846 100644 --- a/src/main/org/codehaus/groovy/reflection/ClassInfo.java +++ b/src/main/org/codehaus/groovy/reflection/ClassInfo.java @@ -481,7 +481,7 @@ public class ClassInfo implements Finalizable { } - public static interface ClassInfoAction { + public interface ClassInfoAction { void onClassInfo(ClassInfo classInfo); } } http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/reflection/GroovyClassValue.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/reflection/GroovyClassValue.java b/src/main/org/codehaus/groovy/reflection/GroovyClassValue.java index a15be3e..909f9b1 100644 --- a/src/main/org/codehaus/groovy/reflection/GroovyClassValue.java +++ b/src/main/org/codehaus/groovy/reflection/GroovyClassValue.java @@ -25,7 +25,7 @@ package org.codehaus.groovy.reflection; */ public interface GroovyClassValue<T> { - public static interface ComputeValue<T>{ + interface ComputeValue<T>{ T computeValue(Class<?> type); } http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/reflection/GroovyClassValueFactory.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/reflection/GroovyClassValueFactory.java b/src/main/org/codehaus/groovy/reflection/GroovyClassValueFactory.java index 3b00638..f3d55e1 100644 --- a/src/main/org/codehaus/groovy/reflection/GroovyClassValueFactory.java +++ b/src/main/org/codehaus/groovy/reflection/GroovyClassValueFactory.java @@ -29,7 +29,7 @@ class GroovyClassValueFactory { * See https://bugs.openjdk.java.net/browse/JDK-8136353 * This issue does not exist on IBM Java (J9) so use ClassValue by default on that JVM. */ - private final static boolean USE_CLASSVALUE = Boolean.valueOf(System.getProperty("groovy.use.classvalue", "IBM J9 VM".equals(System.getProperty("java.vm.name"))?"true":"false")); + private static final boolean USE_CLASSVALUE = Boolean.valueOf(System.getProperty("groovy.use.classvalue", "IBM J9 VM".equals(System.getProperty("java.vm.name"))?"true":"false")); private static final Constructor groovyClassValueConstructor; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java b/src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java index d23c1b5..96c99d9 100644 --- a/src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java +++ b/src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java @@ -1351,7 +1351,7 @@ public class DefaultGroovyMethods extends DefaultGroovyMethodsSupport { return uniqueItems(new IteratorIterableAdapter<T>(self), comparator).listIterator(); } - private static class IteratorIterableAdapter<T> implements Iterable<T> { + private static final class IteratorIterableAdapter<T> implements Iterable<T> { private final Iterator<T> self; private IteratorIterableAdapter(Iterator<T> self) { @@ -8172,7 +8172,7 @@ public class DefaultGroovyMethods extends DefaultGroovyMethodsSupport { * @since 2.4.0 */ public static <E> Map<Integer, E> indexed(Iterable<E> self, int offset) { - LinkedHashMap<Integer, E> result = new LinkedHashMap<Integer, E>(); + Map<Integer, E> result = new LinkedHashMap<Integer, E>(); Iterator<Tuple2<Integer, E>> indexed = indexed(self.iterator(), offset); while (indexed.hasNext()) { Tuple2<Integer, E> next = indexed.next(); http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java b/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java index f8023a3..e7c26fd 100644 --- a/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java +++ b/src/main/org/codehaus/groovy/runtime/IOGroovyMethods.java @@ -1487,7 +1487,7 @@ public class IOGroovyMethods extends DefaultGroovyMethodsSupport { * from the reader when the Writable#writeTo(Writer) is called. * @since 1.0 */ - public static Writable filterLine(Reader reader, final @ClosureParams(value=SimpleType.class, options="java.lang.String") Closure closure) { + public static Writable filterLine(Reader reader, @ClosureParams(value=SimpleType.class, options="java.lang.String") final Closure closure) { final BufferedReader br = new BufferedReader(reader); return new Writable() { public Writer writeTo(Writer out) throws IOException { http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java b/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java index b41b072..55fe502 100644 --- a/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java +++ b/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java @@ -1318,7 +1318,7 @@ public class ResourceGroovyMethods extends DefaultGroovyMethodsSupport { * @see groovy.io.FileType * @since 1.7.1 */ - public static void traverse(final File self, final Map<String, Object> options, final @ClosureParams(value=SimpleType.class, options="java.io.File") Closure closure) + public static void traverse(final File self, final Map<String, Object> options, @ClosureParams(value=SimpleType.class, options="java.io.File") final Closure closure) throws FileNotFoundException, IllegalArgumentException { Number maxDepthNumber = DefaultGroovyMethods.asType(options.remove("maxDepth"), Number.class); int maxDepth = maxDepthNumber == null ? -1 : maxDepthNumber.intValue(); @@ -1396,7 +1396,7 @@ public class ResourceGroovyMethods extends DefaultGroovyMethodsSupport { * @see #traverse(java.io.File, java.util.Map, groovy.lang.Closure) * @since 1.7.1 */ - public static void traverse(final File self, final @ClosureParams(value=SimpleType.class, options="java.io.File") Closure closure) + public static void traverse(final File self, @ClosureParams(value=SimpleType.class, options="java.io.File") final Closure closure) throws FileNotFoundException, IllegalArgumentException { traverse(self, new HashMap<String, Object>(), closure); } http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/runtime/SocketGroovyMethods.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/runtime/SocketGroovyMethods.java b/src/main/org/codehaus/groovy/runtime/SocketGroovyMethods.java index 2162ceb..6582485 100644 --- a/src/main/org/codehaus/groovy/runtime/SocketGroovyMethods.java +++ b/src/main/org/codehaus/groovy/runtime/SocketGroovyMethods.java @@ -158,7 +158,7 @@ public class SocketGroovyMethods extends DefaultGroovyMethodsSupport { * @see java.net.ServerSocket#accept() * @since 1.0 */ - public static Socket accept(ServerSocket serverSocket, final @ClosureParams(value=SimpleType.class, options="java.net.Socket") Closure closure) throws IOException { + public static Socket accept(ServerSocket serverSocket, @ClosureParams(value=SimpleType.class, options="java.net.Socket") final Closure closure) throws IOException { return accept(serverSocket, true, closure); } @@ -175,7 +175,7 @@ public class SocketGroovyMethods extends DefaultGroovyMethodsSupport { * @since 1.7.6 */ public static Socket accept(ServerSocket serverSocket, final boolean runInANewThread, - final @ClosureParams(value=SimpleType.class, options="java.net.Socket") Closure closure) throws IOException { + @ClosureParams(value=SimpleType.class, options="java.net.Socket") final Closure closure) throws IOException { final Socket socket = serverSocket.accept(); if (runInANewThread) { new Thread(new Runnable() { http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java b/src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java index f6af14d..0c6f015 100644 --- a/src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java +++ b/src/main/org/codehaus/groovy/runtime/StringGroovyMethods.java @@ -2619,7 +2619,7 @@ public class StringGroovyMethods extends DefaultGroovyMethodsSupport { * @see #replaceAll(CharSequence, java.util.regex.Pattern, groovy.lang.Closure) */ @Deprecated - public static String replaceAll(final String self, final Pattern pattern, final @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) Closure closure) { + public static String replaceAll(final String self, final Pattern pattern, @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) final Closure closure) { return replaceAll((CharSequence) self, pattern, closure); } @@ -2637,7 +2637,7 @@ public class StringGroovyMethods extends DefaultGroovyMethodsSupport { * @see #replaceAll(CharSequence, CharSequence, groovy.lang.Closure) */ @Deprecated - public static String replaceAll(final String self, final String regex, final @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) Closure closure) { + public static String replaceAll(final String self, final String regex, @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) final Closure closure) { return replaceAll((CharSequence) self, (CharSequence) regex, closure); } @@ -2677,7 +2677,7 @@ public class StringGroovyMethods extends DefaultGroovyMethodsSupport { * @see #replaceFirst(String, String, groovy.lang.Closure) * @since 1.8.2 */ - public static String replaceFirst(final CharSequence self, final CharSequence regex, final @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) Closure closure) { + public static String replaceFirst(final CharSequence self, final CharSequence regex, @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) final Closure closure) { return replaceFirst(self, Pattern.compile(regex.toString()), closure); } @@ -2725,7 +2725,7 @@ public class StringGroovyMethods extends DefaultGroovyMethodsSupport { * @return a CharSequence with replaced content * @since 1.8.2 */ - public static String replaceFirst(final CharSequence self, final Pattern pattern, final @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) Closure closure) { + public static String replaceFirst(final CharSequence self, final Pattern pattern, @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) final Closure closure) { final String s = self.toString(); final Matcher matcher = pattern.matcher(s); if (matcher.find()) { @@ -2744,7 +2744,7 @@ public class StringGroovyMethods extends DefaultGroovyMethodsSupport { * @see #replaceFirst(CharSequence, java.util.regex.Pattern, groovy.lang.Closure) */ @Deprecated - public static String replaceFirst(final String self, final Pattern pattern, final @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) Closure closure) { + public static String replaceFirst(final String self, final Pattern pattern, @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) final Closure closure) { return replaceFirst((CharSequence) self, pattern, closure); } @@ -2762,7 +2762,7 @@ public class StringGroovyMethods extends DefaultGroovyMethodsSupport { * @see #replaceFirst(CharSequence, CharSequence, groovy.lang.Closure) */ @Deprecated - public static String replaceFirst(final String self, final String regex, final @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) Closure closure) { + public static String replaceFirst(final String self, final String regex, @ClosureParams(value=FromString.class, options={"List<String>","String[]"}) final Closure closure) { return replaceFirst((CharSequence) self, (CharSequence) regex, closure); } http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/runtime/metaclass/MetaMethodIndex.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/runtime/metaclass/MetaMethodIndex.java b/src/main/org/codehaus/groovy/runtime/metaclass/MetaMethodIndex.java index fc32607..0598f9a 100644 --- a/src/main/org/codehaus/groovy/runtime/metaclass/MetaMethodIndex.java +++ b/src/main/org/codehaus/groovy/runtime/metaclass/MetaMethodIndex.java @@ -47,8 +47,8 @@ public class MetaMethodIndex { } public static class CacheEntry { - final public Class [] params; - final public MetaMethod method; + public final Class [] params; + public final MetaMethod method; public CacheEntry(final Class[] params, final MetaMethod method) { this.params = params; http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java b/src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java index 8379449..7a289ea 100644 --- a/src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java +++ b/src/main/org/codehaus/groovy/transform/AbstractASTTransformation.java @@ -51,7 +51,6 @@ import java.util.Map; import static groovy.transform.Undefined.isUndefined; import static org.codehaus.groovy.ast.tools.GeneralUtils.getInstanceNonPropertyFieldNames; -import static org.codehaus.groovy.ast.tools.GeneralUtils.getInstancePropertyNames; import static org.codehaus.groovy.ast.tools.GeneralUtils.getSuperNonPropertyFields; public abstract class AbstractASTTransformation implements Opcodes, ASTTransformation, ErrorCollecting { http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java b/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java index e2d5d29..622084b 100644 --- a/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java +++ b/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java @@ -2159,7 +2159,7 @@ public abstract class StaticTypeCheckingSupport { * @return a set of interfaces implemented by this class node */ public static Set<ClassNode> collectAllInterfaces(ClassNode node) { - HashSet<ClassNode> result = new HashSet<ClassNode>(); + Set<ClassNode> result = new HashSet<ClassNode>(); collectAllInterfaces(node, result); return result; } http://git-wip-us.apache.org/repos/asf/groovy/blob/3c7c8748/src/main/org/codehaus/groovy/util/ListHashMap.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/util/ListHashMap.java b/src/main/org/codehaus/groovy/util/ListHashMap.java index 31cd251..b1a141b 100644 --- a/src/main/org/codehaus/groovy/util/ListHashMap.java +++ b/src/main/org/codehaus/groovy/util/ListHashMap.java @@ -21,6 +21,7 @@ package org.codehaus.groovy.util; import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; +import java.util.List; import java.util.Map; import java.util.Set; @@ -205,9 +206,9 @@ public class ListHashMap<K,V> implements Map<K,V> { } public Collection<V> values() { - if (innerMap==null) { - ArrayList<V> list = new ArrayList(size); - for (int i=0; i<size; i++) { + if (innerMap == null) { + List<V> list = new ArrayList<V>(size); + for (int i = 0; i < size; i++) { list.add((V) listValues[i]); } return list;
