Repository: groovy Updated Branches: refs/heads/GROOVY_2_5_X abef8fd9e -> d57c99423
Refine JavaStubGenerator to gain better IO performance (cherry picked from commit 6e2a7dd) Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/d57c9942 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/d57c9942 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/d57c9942 Branch: refs/heads/GROOVY_2_5_X Commit: d57c994237ebb60a1479985319e94b5c02648f0b Parents: abef8fd Author: sunlan <sun...@apache.org> Authored: Tue Dec 12 22:32:17 2017 +0800 Committer: sunlan <sun...@apache.org> Committed: Tue Dec 12 22:54:06 2017 +0800 ---------------------------------------------------------------------- .../groovy/tools/javac/JavaStubGenerator.java | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/d57c9942/src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java b/src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java index a8674b0..f8df25e 100644 --- a/src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java +++ b/src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java @@ -50,10 +50,10 @@ import org.codehaus.groovy.tools.Utilities; import org.codehaus.groovy.transform.trait.Traits; import org.objectweb.asm.Opcodes; +import java.io.BufferedOutputStream; import java.io.File; import java.io.FileNotFoundException; import java.io.FileOutputStream; -import java.io.IOException; import java.io.OutputStreamWriter; import java.io.PrintWriter; import java.io.StringWriter; @@ -95,6 +95,7 @@ public class JavaStubGenerator { dir.mkdirs(); } + private static final int DEFAULT_BUFFER_SIZE = 32 * 1024; // 32K public void generateClass(ClassNode classNode) throws FileNotFoundException { // Only attempt to render our self if our super-class is resolved, else wait for it if (requireSuperResolved && !classNode.getSuperClass().isResolved()) { @@ -113,9 +114,17 @@ public class JavaStubGenerator { toCompile.add(fileName); File file = new File(outputPath, fileName + ".java"); - FileOutputStream fos = new FileOutputStream(file); Charset charset = Charset.forName(encoding); - PrintWriter out = new PrintWriter(new OutputStreamWriter(fos, charset)); + PrintWriter out = + new PrintWriter( + new OutputStreamWriter( + new BufferedOutputStream( + new FileOutputStream(file), + DEFAULT_BUFFER_SIZE + ), + charset + ) + ); try { String packageName = classNode.getPackageName(); @@ -132,11 +141,6 @@ public class JavaStubGenerator { } catch (Exception e) { // ignore } - try { - fos.close(); - } catch (IOException e) { - // ignore - } } }