Repository: groovy Updated Branches: refs/heads/GROOVY_2_5_X bcff55f99 -> 753603f2a
Replace string concatenation in loop with StringBuilder Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/753603f2 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/753603f2 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/753603f2 Branch: refs/heads/GROOVY_2_5_X Commit: 753603f2af2f6131b5003c69d2bf48c90c95d41f Parents: bcff55f Author: Shil Sinha <[email protected]> Authored: Sat Dec 23 10:59:32 2017 -0800 Committer: Shil Sinha <[email protected]> Committed: Sat Dec 23 11:02:26 2017 -0800 ---------------------------------------------------------------------- .../org/codehaus/groovy/runtime/powerassert/SourceText.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/753603f2/src/main/java/org/codehaus/groovy/runtime/powerassert/SourceText.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/runtime/powerassert/SourceText.java b/src/main/java/org/codehaus/groovy/runtime/powerassert/SourceText.java index dbdc78b..6a9f96d 100644 --- a/src/main/java/org/codehaus/groovy/runtime/powerassert/SourceText.java +++ b/src/main/java/org/codehaus/groovy/runtime/powerassert/SourceText.java @@ -54,7 +54,7 @@ public class SourceText { firstLine = stat.getLineNumber(); textOffsets.add(0); - normalizedText = ""; + StringBuilder normalizedTextBuffer = new StringBuilder(); for (int line = stat.getLineNumber(); line <= stat.getLastLineNumber(); line++) { String lineText = sourceUnit.getSample(line, 0, janitor); @@ -72,9 +72,10 @@ public class SourceText { lineText = lineText.trim(); if (line != stat.getLastLineNumber() && lineText.length() > 0) lineText += ' '; - normalizedText += lineText; - textOffsets.add(normalizedText.length()); + normalizedTextBuffer.append(lineText); + textOffsets.add(normalizedTextBuffer.length()); } + normalizedText = normalizedTextBuffer.toString(); } /**
