Fix a syntax error and trivial refactor
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/50ebdf16 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/50ebdf16 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/50ebdf16 Branch: refs/heads/master Commit: 50ebdf1649cf3a7c8c3ce1afcfb888ff8f954766 Parents: 52bb559 Author: sunlan <[email protected]> Authored: Mon Mar 5 18:22:29 2018 +0800 Committer: sunlan <[email protected]> Committed: Mon Mar 5 18:22:29 2018 +0800 ---------------------------------------------------------------------- .../org/codehaus/groovy/classgen/asm/CallSiteWriter.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/50ebdf16/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java b/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java index 334eebd..d4ddc94 100644 --- a/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java +++ b/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java @@ -67,13 +67,13 @@ import static org.objectweb.asm.Opcodes.RETURN; * use this class in your code */ public class CallSiteWriter { - - private static String [] sig = new String [255]; + private static final int SIG_ARRAY_LENGTH = 255; + private static String [] sig = new String [SIG_ARRAY_LENGTH]; private static String getCreateArraySignature(int numberOfArguments) { - if (numberOfArguments >= 255) { + if (numberOfArguments >= SIG_ARRAY_LENGTH) { throw new IllegalArgumentException(String.format( - "The max number of arguments is 255, actual got %s", - numberOfArguments); + "The max number of arguments is %s, actual got %s", + SIG_ARRAY_LENGTH, numberOfArguments)); } if (sig[numberOfArguments] == null) { StringBuilder sb = new StringBuilder("(");
