improve error message plus minor refactoring
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/fd7601dc Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/fd7601dc Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/fd7601dc Branch: refs/heads/GROOVY_2_6_X Commit: fd7601dc47fb0fc2706aee3d2f34c772fed66192 Parents: 96e24c0 Author: paulk <[email protected]> Authored: Tue Mar 6 10:53:34 2018 +1000 Committer: paulk <[email protected]> Committed: Tue Mar 6 10:53:34 2018 +1000 ---------------------------------------------------------------------- .../java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/fd7601dc/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java b/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java index d4ddc94..b99ffe5 100644 --- a/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java +++ b/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java @@ -72,7 +72,7 @@ public class CallSiteWriter { private static String getCreateArraySignature(int numberOfArguments) { if (numberOfArguments >= SIG_ARRAY_LENGTH) { throw new IllegalArgumentException(String.format( - "The max number of arguments is %s, actual got %s", + "The max number of supported arguments is %s, but found %s", SIG_ARRAY_LENGTH, numberOfArguments)); } if (sig[numberOfArguments] == null) { @@ -102,8 +102,7 @@ public class CallSiteWriter { METHOD_OO_DESC = "(Ljava/lang/Object;)Ljava/lang/Object;", CREATE_CSA_METHOD = "$createCallSiteArray"; public static final String CONSTRUCTOR = "<$constructor$>"; - - private final List callSites = new ArrayList(32); + private final List<String> callSites = new ArrayList<String>(32); private int callSiteArrayVarIndex = -1; private final WriterController controller;
