Repository: groovy Updated Branches: refs/heads/master a70c7635c -> bd9a237b1
Update javadoc for `GenericsTypeName` Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/bd9a237b Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/bd9a237b Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/bd9a237b Branch: refs/heads/master Commit: bd9a237b177834f6dd1363a84832fffeb6b745ba Parents: a70c763 Author: Daniel Sun <[email protected]> Authored: Sun Aug 19 20:47:30 2018 +0800 Committer: Daniel Sun <[email protected]> Committed: Sun Aug 19 20:47:30 2018 +0800 ---------------------------------------------------------------------- src/main/java/org/codehaus/groovy/ast/GenericsType.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/bd9a237b/src/main/java/org/codehaus/groovy/ast/GenericsType.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/ast/GenericsType.java b/src/main/java/org/codehaus/groovy/ast/GenericsType.java index 5041fb1..6e8dcc0 100644 --- a/src/main/java/org/codehaus/groovy/ast/GenericsType.java +++ b/src/main/java/org/codehaus/groovy/ast/GenericsType.java @@ -501,7 +501,15 @@ public class GenericsType extends ASTNode { /** * Represents GenericsType name - * TODO In order to distinguish GenericsType with same name(See GROOVY-8409), we should add a property to keep the declaring class full name. + * TODO In order to distinguish GenericsType with same name(See GROOVY-8409), we should add a property to keep the declaring class. + * + * fixing GROOVY-8409 steps: + * 1) change the signature of constructor GenericsTypeName to `GenericsTypeName(String name, ClassNode declaringClass)` + * 2) try to fix all compilation errors(if `GenericsType` has declaringClass property, the step would be a bit easy to fix...) + * 3) run all tests to see whether the change breaks anything + * 4) if all tests pass, congratulations! but if some tests are broken, try to debug and find why... + * + * We should find a way to set declaring class for `GenericsType` first, it can be completed at the resolving phase. */ public static class GenericsTypeName { private String name;
