Trivial refactoring: Move condition to loop (cherry picked from commit 255b94d9aed81e76c1270df5db871c5bd22586be)
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/71ccd39a Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/71ccd39a Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/71ccd39a Branch: refs/heads/GROOVY_2_5_X Commit: 71ccd39a2c135f87f820d54a90b70ece19ebee46 Parents: 2141384 Author: Daniel Sun <[email protected]> Authored: Sun Aug 26 23:51:05 2018 +0800 Committer: Daniel Sun <[email protected]> Committed: Sun Aug 26 23:57:24 2018 +0800 ---------------------------------------------------------------------- src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/71ccd39a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java index b7fa503..4c7230e 100644 --- a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java +++ b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java @@ -110,10 +110,9 @@ public class OptimizerVisitor extends ClassCodeExpressionTransformer { return; } String name; - while (true) { + do { name = "$const$" + index++; - if (currentClass.getDeclaredField(name) == null) break; - } + } while (currentClass.getDeclaredField(name) != null); field = new FieldNode(name, Opcodes.ACC_PRIVATE | Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC | Opcodes.ACC_FINAL, constantExpression.getType(),
