Trivial refactoring: remove redundant String operation
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/9638acdd Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/9638acdd Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/9638acdd Branch: refs/heads/master Commit: 9638acdd7a171be2e3d3f258c8fdbb560d5e376c Parents: a7956c5 Author: Daniel Sun <[email protected]> Authored: Sat Sep 8 11:38:06 2018 +0800 Committer: Daniel Sun <[email protected]> Committed: Sat Sep 8 11:38:06 2018 +0800 ---------------------------------------------------------------------- .../groovy-sql/src/main/java/groovy/sql/ExtractIndexAndSql.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/9638acdd/subprojects/groovy-sql/src/main/java/groovy/sql/ExtractIndexAndSql.java ---------------------------------------------------------------------- diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/ExtractIndexAndSql.java b/subprojects/groovy-sql/src/main/java/groovy/sql/ExtractIndexAndSql.java index c8b67f7..8694ec6 100644 --- a/subprojects/groovy-sql/src/main/java/groovy/sql/ExtractIndexAndSql.java +++ b/subprojects/groovy-sql/src/main/java/groovy/sql/ExtractIndexAndSql.java @@ -191,7 +191,7 @@ class ExtractIndexAndSql { Matcher matcher = NAMED_QUERY_PATTERN.matcher(sql); while (matcher.find()) { - newSql.append(sql.substring(txtIndex, matcher.start())).append('?'); + newSql.append(sql, txtIndex, matcher.start()).append('?'); String indexStr = matcher.group(1); if (indexStr == null) indexStr = matcher.group(3); int index = (indexStr == null || indexStr.length() == 0 || ":".equals(indexStr)) ? 0 : Integer.parseInt(indexStr) - 1;
