Repository: groovy Updated Branches: refs/heads/master 44ef38bca -> fae1909bd
Trivial refactoring: extract constants Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/fae1909b Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/fae1909b Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/fae1909b Branch: refs/heads/master Commit: fae1909bd950039670cceeea6ceadc2508df0f71 Parents: 44ef38b Author: Daniel Sun <[email protected]> Authored: Sat Sep 15 20:58:10 2018 +0800 Committer: Daniel Sun <[email protected]> Committed: Sat Sep 15 20:58:26 2018 +0800 ---------------------------------------------------------------------- .../groovy/runtime/metaclass/MetaClassRegistryImpl.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/fae1909b/src/main/java/org/codehaus/groovy/runtime/metaclass/MetaClassRegistryImpl.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/runtime/metaclass/MetaClassRegistryImpl.java b/src/main/java/org/codehaus/groovy/runtime/metaclass/MetaClassRegistryImpl.java index eda5f06..8b59d40 100644 --- a/src/main/java/org/codehaus/groovy/runtime/metaclass/MetaClassRegistryImpl.java +++ b/src/main/java/org/codehaus/groovy/runtime/metaclass/MetaClassRegistryImpl.java @@ -63,6 +63,8 @@ public class MetaClassRegistryImpl implements MetaClassRegistry{ */ @Deprecated public static final String MODULE_META_INF_FILE = "META-INF/services/org.codehaus.groovy.runtime.ExtensionModule"; + private static final MetaClass[] EMPTY_METACLASS_ARRAY = new MetaClass[0]; + private static final MetaClassRegistryChangeEventListener[] EMPTY_METACLASSREGISTRYCHANGEEVENTLISTENER_ARRAY = new MetaClassRegistryChangeEventListener[0]; private final boolean useAccessible; @@ -414,7 +416,7 @@ public class MetaClassRegistryImpl implements MetaClassRegistry{ new ArrayList<MetaClassRegistryChangeEventListener>(changeListenerList.size()+nonRemoveableChangeListenerList.size()); ret.addAll(nonRemoveableChangeListenerList); ret.addAll(changeListenerList); - return ret.toArray(new MetaClassRegistryChangeEventListener[0]); + return ret.toArray(EMPTY_METACLASSREGISTRYCHANGEEVENTLISTENER_ARRAY); } } @@ -458,7 +460,7 @@ public class MetaClassRegistryImpl implements MetaClassRegistry{ * @return the iterator. */ public Iterator iterator() { - final MetaClass[] refs = metaClassInfo.toArray(new MetaClass[0]); + final MetaClass[] refs = metaClassInfo.toArray(EMPTY_METACLASS_ARRAY); return new Iterator() { // index in the ref array
