Repository: groovy Updated Branches: refs/heads/GROOVY_2_5_X 3e4173039 -> 8a9c78f69
GROOVY-8871: Long Constants Defined in Groovy 2.5.3 Under OpenJDK 11 Cause an IllegalAccessError Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/8a9c78f6 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/8a9c78f6 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/8a9c78f6 Branch: refs/heads/GROOVY_2_5_X Commit: 8a9c78f696fdf8a23104bf037e2559b4fcfadc74 Parents: 3e41730 Author: Paul King <pa...@asert.com.au> Authored: Thu Nov 8 20:32:28 2018 +1000 Committer: Paul King <pa...@asert.com.au> Committed: Thu Nov 8 20:33:18 2018 +1000 ---------------------------------------------------------------------- src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/8a9c78f6/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java index 4c7230e..c9313dd 100644 --- a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java +++ b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java @@ -113,8 +113,9 @@ public class OptimizerVisitor extends ClassCodeExpressionTransformer { do { name = "$const$" + index++; } while (currentClass.getDeclaredField(name) != null); + // TODO consider moving initcode to <clinit> and remaking field final field = new FieldNode(name, - Opcodes.ACC_PRIVATE | Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC | Opcodes.ACC_FINAL, + Opcodes.ACC_PRIVATE | Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC, constantExpression.getType(), currentClass, constantExpression);
