This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push:
new fc0df26 use a specified version of checkstyle
fc0df26 is described below
commit fc0df262260d25c41031c4c551499d042ee51e09
Author: Paul King <[email protected]>
AuthorDate: Thu Jan 23 20:45:28 2020 +1000
use a specified version of checkstyle
---
config/checkstyle/checkstyle.xml | 6 +++---
gradle/quality.gradle | 5 +++--
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index 18e6dc6..5ce331c 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -20,8 +20,8 @@
-->
<!DOCTYPE module PUBLIC
- "-//Puppy Crawl//DTD Check Configuration 1.1//EN"
- "http://www.puppycrawl.com/dtds/configuration_1_1.dtd";>
+ "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+ "https://checkstyle.org/dtds/configuration_1_3.dtd";>
<!--
A Checkstyle configuration that checks against most of the recommendations
@@ -147,7 +147,7 @@
parameters final in cases where confusion is possible -->
<!--<module name="ParameterAssignment"/>-->
<module name="IllegalType">
- <property name="format" value="^$"/>
+ <property name="illegalAbstractClassNameFormat" value="^$"/>
<!-- otherwise default of '*Abstract' is illegal -->
<property name="illegalClassNames"
value="java.util.GregorianCalendar, java.util.Hashtable, java.util.HashSet,
java.util.HashMap, java.util.ArrayList, java.util.LinkedHashMap,
java.util.LinkedHashSet, java.util.TreeSet, java.util.TreeMap,
java.util.Vector"/>
</module>
diff --git a/gradle/quality.gradle b/gradle/quality.gradle
index 2696a86..9f3d202 100644
--- a/gradle/quality.gradle
+++ b/gradle/quality.gradle
@@ -37,11 +37,12 @@ allprojects { proj ->
substitute module("org.codehaus.groovy:groovy-xml") with
project(":groovy-xml")
substitute module("org.codehaus.groovy:groovy-groovydoc") with
project(":groovy-groovydoc")
}
-
+
exclude module: 'groovy-all'
}
-
+
dependencies {
+ checkstyle "com.puppycrawl.tools:checkstyle:8.28"
codenarc "org.codenarc:CodeNarc:1.5"
spotbugs 'com.github.spotbugs:spotbugs:3.1.11'
if (proj.name.contains('jaxb') &&
JavaVersion.current().isJava9Compatible()) {
