This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch GROOVY_3_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/GROOVY_3_0_X by this push:
     new bba608e  Trivial tweak: reduce method calls of `charAt`
bba608e is described below

commit bba608ebaae3329bce707708793401daa482f8f7
Author: Daniel Sun <[email protected]>
AuthorDate: Sun Jul 12 14:55:29 2020 +0800

    Trivial tweak: reduce method calls of `charAt`
    
    (cherry picked from commit 6d610ba519a289243d163b91f39793d8220dd342)
---
 src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java 
b/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java
index 190462c..787009f 100644
--- a/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java
+++ b/src/main/java/org/apache/groovy/ast/tools/MethodNodeUtils.java
@@ -86,17 +86,17 @@ public class MethodNodeUtils {
         if (nameLength > 2) {
             switch (name.charAt(0)) {
                 case 'g':
-                    if (nameLength > 3 && name.charAt(1) == 'e' && 
name.charAt(2) == 't' && mNode.getParameters().length == 0 && 
!mNode.getReturnType().equals(ClassHelper.VOID_TYPE)) {
+                    if (nameLength > 3 && mNode.getParameters().length == 0  
&& name.charAt(1) == 'e' && name.charAt(2) == 't' && 
!mNode.getReturnType().equals(ClassHelper.VOID_TYPE)) {
                         return decapitalize(name.substring(3));
                     }
                     break;
                 case 's':
-                    if (nameLength > 3 && name.charAt(1) == 'e' && 
name.charAt(2) == 't' && mNode.getParameters().length == 1 /*&& 
mNode.getReturnType().equals(ClassHelper.VOID_TYPE)*/) {
+                    if (nameLength > 3 && mNode.getParameters().length == 1 && 
name.charAt(1) == 'e' && name.charAt(2) == 't'  /*&& 
mNode.getReturnType().equals(ClassHelper.VOID_TYPE)*/) {
                         return decapitalize(name.substring(3));
                     }
                     break;
                 case 'i':
-                    if (name.charAt(1) == 's' && mNode.getParameters().length 
== 0 && (mNode.getReturnType().equals(ClassHelper.boolean_TYPE) /*|| 
mNode.getReturnType().equals(ClassHelper.Boolean_TYPE)*/)) {
+                    if (mNode.getParameters().length == 0 && name.charAt(1) == 
's' && (mNode.getReturnType().equals(ClassHelper.boolean_TYPE) /*|| 
mNode.getReturnType().equals(ClassHelper.Boolean_TYPE)*/)) {
                         return decapitalize(name.substring(2));
                     }
                     break;

Reply via email to