[groovy] branch master updated: GROOVY-10710: operator == is slow when comparing primitive arrays and lists

[paulk]

This is an automated email from the ASF dual-hosted git repository.

paulk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 5703d32656 GROOVY-10710: operator == is slow when comparing primitive 
arrays and lists
5703d32656 is described below

commit 5703d326565365adef1e2d544e61e8cd96f6ac96
Author: Paul King <pa...@asert.com.au>
AuthorDate: Tue Aug 16 22:03:47 2022 +1000

    GROOVY-10710: operator == is slow when comparing primitive arrays and lists
---
 .../groovy/ast/ClassCodeExpressionTransformer.java | 28 ++++++++++------------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git 
a/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java 
b/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java
index af5cfe9b22..b2841a6efe 100644
--- a/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java
+++ b/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java
@@ -43,26 +43,24 @@ import java.util.Map;
 public abstract class ClassCodeExpressionTransformer extends 
ClassCodeVisitorSupport implements ExpressionTransformer {
 
     /**
-     * <strong>GOTCHA</strong>: This method does not visit Expressions within 
Closures, for historical
-     * reason.  If you want those Expressions to be visited, you can do this:
+     * <strong>NOTE</strong>: This method does not visit Expressions within 
Closures,
+     * for performance and historical reasons.
+     * If you want those Expressions to be visited, you can do this:
      * <pre>
      * {@code
      * public class YourTransformer extends ClassCodeExpressionTransformer {
-     *  ...
+     *   ...
      *
-     *  @Override
-     *  public Expression transform(final Expression expr) {
-     *    if (expr instanceof ClosureExpression) {
-     *      expr.visit(this);
+     *   @Override
+     *   public Expression transform(final Expression expr) {
+     *     if (expr instanceof ClosureExpression) {
+     *       expr.visit(this);
      *
-     *      return expr;
-     *    }
-     *
-     *    // ... your custom instanceof + expression transformation
-     *    // ...
-     *  }
-     * }
-     * }
+     *       return expr;
+     *     }
+     *     // ...
+     *   }
+     * }}
      * </pre>
      */
     @Override