This is an automated email from the ASF dual-hosted git repository. paulk pushed a commit to branch GROOVY_4_0_X in repository https://gitbox.apache.org/repos/asf/groovy.git
commit c5121849bcbaea314006c3b387aa16d451643617 Author: Paul King <[email protected]> AuthorDate: Tue Aug 16 22:03:47 2022 +1000 GROOVY-10710: operator == is slow when comparing primitive arrays and lists --- .../groovy/ast/ClassCodeExpressionTransformer.java | 28 ++++++++++------------ 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java b/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java index 7f04f80bda..5df1c81b4e 100644 --- a/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java +++ b/src/main/java/org/codehaus/groovy/ast/ClassCodeExpressionTransformer.java @@ -43,26 +43,24 @@ import java.util.Map; public abstract class ClassCodeExpressionTransformer extends ClassCodeVisitorSupport implements ExpressionTransformer { /** - * <strong>GOTCHA</strong>: This method does not visit Expressions within Closures, for historical - * reason. If you want those Expressions to be visited, you can do this: + * <strong>NOTE</strong>: This method does not visit Expressions within Closures, + * for performance and historical reasons. + * If you want those Expressions to be visited, you can do this: * <pre> * {@code * public class YourTransformer extends ClassCodeExpressionTransformer { - * ... + * ... * - * @Override - * public Expression transform(final Expression expr) { - * if (expr instanceof ClosureExpression) { - * expr.visit(this); + * @Override + * public Expression transform(final Expression expr) { + * if (expr instanceof ClosureExpression) { + * expr.visit(this); * - * return expr; - * } - * - * // ... your custom instanceof + expression transformation - * // ... - * } - * } - * } + * return expr; + * } + * // ... + * } + * }} * </pre> */ @Override
