This is an automated email from the ASF dual-hosted git repository.

emilles pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit 6312fec7628d18c7bc494c2ed9438181f8967dec
Author: Eric Milles <[email protected]>
AuthorDate: Wed Sep 18 08:57:46 2024 -0500

    GROOVY-10920: SC: convert `void` and non-primitive operands to `boolean`
---
 .../transform/sc/transformers/BooleanExpressionTransformer.java       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/src/main/java/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java
 
b/src/main/java/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java
index 73f5b2f2ef..5f3fdd9af7 100644
--- 
a/src/main/java/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java
+++ 
b/src/main/java/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java
@@ -119,8 +119,8 @@ class BooleanExpressionTransformer {
                 int mark = os.getStackLength();
                 getExpression().visit(visitor);
 
-                if (ClassHelper.isPrimitiveType(type) && 
!ClassHelper.isPrimitiveVoid(type)) { // GROOVY-10920
-                    BytecodeHelper.convertPrimitiveToBoolean(mv, type);
+                if (ClassHelper.isPrimitiveType(os.getTopOperand())) { // 
GROOVY-10920
+                    BytecodeHelper.convertPrimitiveToBoolean(mv, 
os.getTopOperand());
                     os.replace(ClassHelper.boolean_TYPE);
                     return;
                 }

Reply via email to