This is an automated email from the ASF dual-hosted git repository. sunlan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push: new 9e1f90c70a Trivial refactoring: extract variables 9e1f90c70a is described below commit 9e1f90c70adac7b86fc9ba6c543fcf36e93834ad Author: Daniel Sun <sun...@apache.org> AuthorDate: Sun Jan 12 05:00:15 2025 +0900 Trivial refactoring: extract variables --- src/main/java/org/codehaus/groovy/reflection/CachedClass.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/codehaus/groovy/reflection/CachedClass.java b/src/main/java/org/codehaus/groovy/reflection/CachedClass.java index a80d27ceb4..574770ce5b 100644 --- a/src/main/java/org/codehaus/groovy/reflection/CachedClass.java +++ b/src/main/java/org/codehaus/groovy/reflection/CachedClass.java @@ -58,10 +58,12 @@ public class CachedClass { } private static <M extends AccessibleObject & Member> boolean isAccessibleOrCanSetAccessible(M m) { - if (isPublic(m.getModifiers()) && m.getDeclaringClass().getPackageName().startsWith("sun.")) { + final int modifiers = m.getModifiers(); + final Class<?> declaringClass = m.getDeclaringClass(); + if (isPublic(modifiers) && declaringClass.getPackageName().startsWith("sun.")) { return false; } - if (isProtected(m.getModifiers()) && isPublic(m.getDeclaringClass().getModifiers())) { + if (isProtected(modifiers) && isPublic(declaringClass.getModifiers())) { return true; } return ReflectionUtils.checkCanSetAccessible(m, CachedClass.class);