This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push:
new d69299ecfd GROOVY-10240: Compact constructor should have the same name
as record
d69299ecfd is described below
commit d69299ecfdc8f6c57b74c3ab01455a24b1dfaa52
Author: Daniel Sun <[email protected]>
AuthorDate: Sat Mar 29 16:16:58 2025 +0900
GROOVY-10240: Compact constructor should have the same name as record
---
.../apache/groovy/parser/antlr4/AstBuilder.java | 2 +-
.../fail/RecordDeclaration_17x.groovy | 25 ++++++++++++++++++++++
.../groovy/parser/antlr4/SyntaxErrorTest.groovy | 1 +
3 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
b/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
index e6f6a56d5b..24a40bc8a7 100644
--- a/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
+++ b/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
@@ -1670,7 +1670,7 @@ public class AstBuilder extends
GroovyParserBaseVisitor<Object> {
String methodName = this.visitMethodName(ctx.methodName());
String className = classNode.getNodeMetaData(CLASS_NAME);
if (!methodName.equals(className)) {
- createParsingFailedException("Compact constructor should have the
same name as record: " + className, ctx.methodName());
+ throw createParsingFailedException("Compact constructor should
have the same name as record: " + className, ctx.methodName());
}
Parameter[] header = classNode.getNodeMetaData(RECORD_HEADER);
diff --git a/src/test-resources/fail/RecordDeclaration_17x.groovy
b/src/test-resources/fail/RecordDeclaration_17x.groovy
new file mode 100644
index 0000000000..d9d3f035f8
--- /dev/null
+++ b/src/test-resources/fail/RecordDeclaration_17x.groovy
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package fail
+
+record Person(String name, int age) {
+ Person2 {
+ // Compact constructor should have the same name as record
+ }
+}
diff --git a/src/test/org/apache/groovy/parser/antlr4/SyntaxErrorTest.groovy
b/src/test/org/apache/groovy/parser/antlr4/SyntaxErrorTest.groovy
index b701f682ff..52654b8b38 100644
--- a/src/test/org/apache/groovy/parser/antlr4/SyntaxErrorTest.groovy
+++ b/src/test/org/apache/groovy/parser/antlr4/SyntaxErrorTest.groovy
@@ -497,6 +497,7 @@ final class SyntaxErrorTest {
TestUtils.doRunAndShouldFail('fail/RecordDeclaration_14x.groovy')
TestUtils.doRunAndShouldFail('fail/RecordDeclaration_15x.groovy')
TestUtils.doRunAndShouldFail('fail/RecordDeclaration_16x.groovy')
+ TestUtils.doRunAndShouldFail('fail/RecordDeclaration_17x.groovy')
}
@Test
