This is an automated email from the ASF dual-hosted git repository.
paulk-asert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push:
new 88c227f7e0 fix test flakiness
88c227f7e0 is described below
commit 88c227f7e0c025699cc8b72ff6c0a90c83c83dea
Author: Paul King <[email protected]>
AuthorDate: Mon May 4 22:17:24 2026 +1000
fix test flakiness
---
.../runtime/m12n/ExtensionModuleHelperForTests.groovy | 13 +++++++++++++
.../codehaus/groovy/runtime/m12n/ExtensionModuleTest.groovy | 6 +++---
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git
a/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleHelperForTests.groovy
b/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleHelperForTests.groovy
index 3b2d202016..2281e11aa1 100644
---
a/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleHelperForTests.groovy
+++
b/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleHelperForTests.groovy
@@ -28,6 +28,7 @@ final class ExtensionModuleHelperForTests {
File baseDir = File.createTempDir()
File sourceFile = new File(baseDir, 'Temp.groovy')
sourceFile << """import org.codehaus.groovy.runtime.m12n.*
+ import static groovy.test.GroovyAssert.assertScript
class TempTest extends $baseTestClass {
@org.junit.jupiter.api.Test
void testCode() {
@@ -36,15 +37,27 @@ final class ExtensionModuleHelperForTests {
}
import org.junit.platform.launcher.core.*
+ import
org.junit.platform.launcher.listeners.SummaryGeneratingListener
import static
org.junit.platform.engine.discovery.DiscoverySelectors.*
def launcher = LauncherFactory.create()
+ def listener = new SummaryGeneratingListener()
+ launcher.registerTestExecutionListeners(listener)
def testPlan = launcher.discover(
LauncherDiscoveryRequestBuilder.request().selectors(
selectClass("TempTest")
).build()
)
launcher.execute(testPlan)
+ // JUnit Platform's launcher is silent on failure; surface
failures via
+ // stderr so the parent process (doInFork) detects them as stray
lines.
+ def summary = listener.summary
+ if (summary.totalFailureCount) {
+ summary.failures.each { f ->
+ System.err.println('TEST FAILED: ' +
f.testIdentifier.displayName + ' :: ' + f.exception)
+ f.exception.printStackTrace(System.err)
+ }
+ }
"""
Set<String> cp =
System.getProperty('java.class.path').split(File.pathSeparator) as Set
diff --git
a/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleTest.groovy
b/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleTest.groovy
index 5c79b2f7c7..3bba1357b3 100644
---
a/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleTest.groovy
+++
b/src/test/groovy/org/codehaus/groovy/runtime/m12n/ExtensionModuleTest.groovy
@@ -56,7 +56,7 @@ final class ExtensionModuleTest {
def resolver = "@GrabResolver('$jarURL')"
assertScript resolver + """
- @Grab(value='module-test:module-test:1.4', changing='true')
+ @Grab(value='module-test:module-test:1.4', changing=true)
import org.codehaus.groovy.runtime.m12n.*
// ensure that the module is now loaded
@@ -88,7 +88,7 @@ final class ExtensionModuleTest {
def resolver = "@GrabResolver('$jarURL')"
assertScript resolver + """
- @Grab(value='module-test:module-test:1.4', changing='true')
+ @Grab(value='module-test:module-test:1.4', changing=true)
import org.codehaus.groovy.runtime.m12n.*
def map = [:]
@@ -112,7 +112,7 @@ final class ExtensionModuleTest {
assertScript """
@GrabResolver('$jarURL')
- @Grab(value='module-test:module-test:1.4', changing='true')
+ @Grab(value='module-test:module-test:1.4', changing=true)
import org.codehaus.groovy.runtime.m12n.*
assert 'test'.groovy7225() == 'test: ok'
