Skip SwingBuilderTest#testContainment, 
SwingBuilderTest#testEnhancedValueArguments and 
SwingBuilderTest#testNamedWidgetCreation on builds.apache.org on windows, 
because these always fail.

The test all use Filechooser, which seems bugy on Windows e.g.: 
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6973685


Project: http://git-wip-us.apache.org/repos/asf/incubator-groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-groovy/commit/06415b9c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-groovy/tree/06415b9c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-groovy/diff/06415b9c

Branch: refs/heads/GROOVY_2_4_X
Commit: 06415b9cc20b39e463597072e6ca6d673e71c2d2
Parents: 05dab66
Author: pascalschumacher <pascalschumac...@gmx.net>
Authored: Sat Oct 24 14:20:26 2015 +0200
Committer: pascalschumacher <pascalschumac...@gmx.net>
Committed: Sat Oct 24 15:42:33 2015 +0200

----------------------------------------------------------------------
 .../groovy/groovy/swing/SwingBuilderTest.groovy | 79 ++++++++++++++++++++
 1 file changed, 79 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-groovy/blob/06415b9c/subprojects/groovy-swing/src/test/groovy/groovy/swing/SwingBuilderTest.groovy
----------------------------------------------------------------------
diff --git 
a/subprojects/groovy-swing/src/test/groovy/groovy/swing/SwingBuilderTest.groovy 
b/subprojects/groovy-swing/src/test/groovy/groovy/swing/SwingBuilderTest.groovy
index 9e6e1b1..7a609d6 100644
--- 
a/subprojects/groovy-swing/src/test/groovy/groovy/swing/SwingBuilderTest.groovy
+++ 
b/subprojects/groovy-swing/src/test/groovy/groovy/swing/SwingBuilderTest.groovy
@@ -18,6 +18,10 @@
  */
 package groovy.swing
 
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.JUnit4
+
 import javax.swing.JPopupMenu.Separator as JPopupMenu_Separator
 import javax.swing.JToolBar.Separator as JToolBar_Separator
 
@@ -32,8 +36,21 @@ import javax.swing.text.NumberFormatter
 import java.awt.*
 import javax.swing.*
 
+import static org.junit.Assume.assumeFalse
+
+@RunWith(JUnit4)
 class SwingBuilderTest extends GroovySwingTestCase {
 
+    private static final boolean buildsApacheOrg = new File('.').absolutePath 
=~ /jenkins|hudson/
+    private static final boolean windows = 
System.properties['os.name'].toLowerCase().contains('windows')
+
+    private assumeNotOnBuildsApacheOrgAndNotOnWindows() {
+        assumeFalse('''Filechooser seems bugy on Windows e.g.: 
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6973685
+on builds.apache.org these test fail with: java.lang.NullPointerException: at 
sun.awt.shell.Win32ShellFolder2.access$200(Win32ShellFolder2.java:72)
+Therefore we ship them on there.''', buildsApacheOrg && windows)
+    }
+
+    @Test
     void testWidgetId() {
         testInEDT {
 
@@ -58,7 +75,10 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testNamedWidgetCreation() {
+        assumeNotOnBuildsApacheOrgAndNotOnWindows()
+
         testInEDT {
             def topLevelWidgets = [
                     frame: [JFrame, true],
@@ -80,6 +100,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testLayoutCreation() {
         testInEDT {
 
@@ -101,6 +122,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testGridBagFactory() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -123,6 +145,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testBorderLayout() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -141,6 +164,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testLayoutConstraintsProperty() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -152,6 +176,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testWidgetCreation() {
         testInEDT {
 
@@ -203,6 +228,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testButtonGroup() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -236,6 +262,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testButtonGroupOnlyForButtons() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -247,6 +274,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testWidget() {
         testInEDT {
 
@@ -259,6 +287,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testSplitPane() {
         testInEDT {
 
@@ -281,6 +310,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testNestedWindows() {
         testInEDT {
 
@@ -311,6 +341,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testFrames() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -323,6 +354,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testDialogs() {
         testInEDT {
 
@@ -344,6 +376,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testWindows() {
         testInEDT {
 
@@ -354,6 +387,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testNodeCreation() {
         testInEDT {
 
@@ -374,6 +408,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testSetMnemonic() {
         testInEDT {
 
@@ -399,6 +434,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testBuilderProperties() {
         testInEDT {
 
@@ -407,6 +443,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testFormattedTextField() {
         testInEDT {
 
@@ -424,6 +461,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testScrollPane() {
         testInEDT {
 
@@ -437,6 +475,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testComboBox() {
         testInEDT {
 
@@ -451,6 +490,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testList() {
         testInEDT {
 
@@ -476,6 +516,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testMisplacedActionsAreIgnored() {
         testInEDT {
 
@@ -494,6 +535,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testBoxLayout() {
         testInEDT {
 
@@ -513,6 +555,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testKeystrokesWithinActions() {
         testInEDT {
 
@@ -541,6 +584,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testActionClosures() {
         testInEDT {
 
@@ -581,6 +625,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testSetAccelerator() {
         testInEDT {
 
@@ -603,6 +648,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         return action
     }
 
+    @Test
     void testSetAcceleratorShortcuts() {
         testInEDT {
 
@@ -619,6 +665,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testBorderLayoutConstraints() {
         testInEDT {
 
@@ -650,6 +697,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testSetConstraints() {
         testInEDT {
 
@@ -660,6 +708,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testSetToolTipText() {
         testInEDT {
 
@@ -671,6 +720,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testAttributeOrdering() {
         testInEDT {
 
@@ -695,6 +745,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testWidgetPassthroughConstraints() {
         testInEDT {
 
@@ -708,6 +759,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testGROOVY1837ReuseAction() {
         testInEDT {
 
@@ -723,6 +775,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testSeparators() {
         testInEDT {
 
@@ -742,6 +795,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testCollectionNodes() {
         testInEDT {
 
@@ -753,6 +807,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testFactoryCornerCases() {
         testInEDT {
 
@@ -769,6 +824,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testFactoryLogging() {
         testInEDT {
 
@@ -781,7 +837,10 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testEnhancedValueArguments() {
+        assumeNotOnBuildsApacheOrgAndNotOnWindows()
+
         testInEDT {
 
             def swing = new SwingBuilder()
@@ -983,6 +1042,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         instancePass = true
     }
 
+    @Test
     void testEDT() {
         if (HeadlessTestSupport.headless) return
         def swing = new SwingBuilder()
@@ -1000,6 +1060,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         assert instancePass
     }
 
+    @Test
     void testDoLater() {
         if (HeadlessTestSupport.headless) return
         def swing = new SwingBuilder()
@@ -1041,6 +1102,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         assert instancePass
     }
 
+    @Test
     void testDoOutside() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1084,6 +1146,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testJumbledThreading() {
         if (HeadlessTestSupport.headless) return;
 
@@ -1165,6 +1228,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         assert swing != oldSwing
     }
 
+    @Test
     void testParallelBuild() {
         if (HeadlessTestSupport.headless) return;
 
@@ -1189,6 +1253,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         assert l.parent == null
     }
 
+    @Test
     void testDispose() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1211,6 +1276,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testPackAndShow() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1244,7 +1310,10 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testContainment() {
+        assumeNotOnBuildsApacheOrgAndNotOnWindows()
+
         testInEDT {
             def swing = new SwingBuilder()
 
@@ -1345,6 +1414,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testMenus() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1390,6 +1460,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testLookAndFeel() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1442,6 +1513,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testMultiLookAndFeel() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1468,6 +1540,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testBorders() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1561,6 +1634,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testBorderAttachment() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1587,6 +1661,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testRenderer() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1621,6 +1696,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testNoParent() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1636,6 +1712,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testClientProperties() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1651,6 +1728,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testKeyStrokeAction() {
         testInEDT {
             def swing = new SwingBuilder()
@@ -1703,6 +1781,7 @@ class SwingBuilderTest extends GroovySwingTestCase {
         }
     }
 
+    @Test
     void testAutomaticNameBasedOnIdAttribute() {
         testInEDT {
             def swing = new SwingBuilder()

Reply via email to