[ 
https://issues.apache.org/jira/browse/GUACAMOLE-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306925#comment-16306925
 ] 

Michael Jumper commented on GUACAMOLE-350:
------------------------------------------

Guacamole also currently imposes a hard limit of 8192 characters per 
instruction at the libguac level. From 
[{{guacamole/parser-constants.h}}|https://github.com/apache/guacamole-server/blob/f72de10328ae39fcbf067333b0c2a2c9aecc441b/src/libguac/guacamole/parser-constants.h#L29-L32]:

{code:none}
/**
 * The maximum number of characters per instruction.
 */
#define GUAC_INSTRUCTION_MAX_LENGTH 8192
{code}

Though changes such as those proposed here will be necessary for larger values 
to be stored within the database, additional changes to the protocol itself 
(or, at a minimum, to libguac) will be necessary to allow such larger values to 
actually be received by guacd. As it is, attempting to pass a value which 
results in the instruction exceeding the maximum length will cause the 
connection to be summarily closed due to an instruction parsing error.

> Can't handle ssh key bigger than 4096 lengh
> -------------------------------------------
>
>                 Key: GUACAMOLE-350
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-350
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-auth-jdbc
>    Affects Versions: 0.9.12-incubating
>            Reporter: Alexandre GALTIER
>            Priority: Minor
>             Fix For: 0.9.14
>
>
> Because of guacamole_connection_parameter/parameter_value site set to 4096, 
> keys bigger than 1024 bits can't be used.
> Update to 8192 could be enough (keys bigger than 10240 bits).
> Needs :
> . Database creation : change parameter_value from 4096 to 8192 
> (incubator-guacamole-client/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/001-create-schema.sql)
>  + 
> (incubator-guacamole-client/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/schema/001-create-schema.sql)
> . Mysql Database upgrade : ALTER TABLE guacamole_connection_parameter MODIFY 
> parameter_value VARCHAR(8192);
> . don't know for postgresql
> Regards,



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to