[
https://issues.apache.org/jira/browse/GUACAMOLE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326492#comment-16326492
]
Ryan Underwood commented on GUACAMOLE-482:
------------------------------------------
I agree with both of your comments. Line 432 of video.c is the same call. I
won't spend any time looking to see if _all_ return values are checked for
validity throughout all of guacenc. Maybe a linter can provide hints? You can
close this report and/or create a new one to address your observation.
I think it would be useful to *at least* log the fact that an error return
value was present, even if it continues processing, so that users aren't
blindly expecting the resultant video file(s) to be issue-free.
> Possible unreachable code in guacenc
> ------------------------------------
>
> Key: GUACAMOLE-482
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-482
> Project: Guacamole
> Issue Type: Bug
> Components: guacenc
> Affects Versions: 0.9.13-incubating
> Environment: using provided dockerfile build
> Reporter: Ryan Underwood
> Priority: Trivial
>
> In this file:
> https://github.com/apache/guacamole-server/blob/master/src/guacenc/display-sync.c
> line 52, the function called "guacenc_video_advance_timeline" doesn't appear
> to have a path that can return 1.
> Reporting because I wasn't sure if this was an artifact from a refactor, a
> bug where guacenc_video_advance_timeline _should_ have a path that returns 1,
> or if it was just a bit of extra code that can go away.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
