[ 
https://issues.apache.org/jira/browse/GUACAMOLE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Jumper resolved GUACAMOLE-500.
--------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0

> Terminal build fails against GCC 7
> ----------------------------------
>
>                 Key: GUACAMOLE-500
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-500
>             Project: Guacamole
>          Issue Type: Bug
>          Components: Terminal
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> [As reported in the mailing 
> lists|https://lists.apache.org/thread.html/2b8ec4c76f4c4832672df80eb460ec14ac558cdadf156422f0588d33@%3Cuser.guacamole.apache.org%3E],
>  when guacamole-server is built against GCC 7, an additional warning is 
> flagged within {{typescript.c}}, resulting in the build failing:
> {code:none}
> ...
> Making all in src/terminal
> make[2]: Entering directory 
> '/home/mjumper/apache/guacamole/guacamole-server/src/terminal'
>   CC       libguac_terminal_la-buffer.lo
>   CC       libguac_terminal_la-char_mappings.lo
>   CC       libguac_terminal_la-common.lo
>   CC       libguac_terminal_la-display.lo
>   CC       libguac_terminal_la-named-colors.lo
>   CC       libguac_terminal_la-palette.lo
>   CC       libguac_terminal_la-scrollbar.lo
>   CC       libguac_terminal_la-terminal.lo
>   CC       libguac_terminal_la-terminal_handlers.lo
>   CC       libguac_terminal_la-typescript.lo
> typescript.c: In function ‘guac_terminal_typescript_alloc’:
> typescript.c:133:46: error: ‘%s’ directive writing 6 bytes into a region of 
> size between 0 and 2047 [-Werror=format-overflow=]
>      sprintf(typescript->timing_filename, "%s.%s", typescript->data_filename,
>                                               ^~
> typescript.c:133:5: note: ‘sprintf’ output between 8 and 2055 bytes into a 
> destination of size 2048
>      sprintf(typescript->timing_filename, "%s.%s", typescript->data_filename,
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>              GUAC_TERMINAL_TYPESCRIPT_TIMING_SUFFIX);
>              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[2]: *** [Makefile:572: libguac_terminal_la-typescript.lo] Error 1
> make[2]: Leaving directory 
> '/home/mjumper/apache/guacamole/guacamole-server/src/terminal'
> make[1]: *** [Makefile:517: all-recursive] Error 1
> make[1]: Leaving directory '/home/mjumper/apache/guacamole/guacamole-server'
> make: *** [Makefile:439: all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to