[
https://issues.apache.org/jira/browse/GUACAMOLE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Jumper reopened GUACAMOLE-482:
--------------------------------------
Reopening as I'm now seeing a regression in guacenc. Session recordings which
would encode correctly to .m4v with 0.9.14 are now failing with:
{quote}
guacenc: WARNING: Encoding failed for 1 of 1 file(s).
{quote}
git bisect reveals the following commit broke things:
{code:none}
19b5050fbf6a61910ca145089042800211b93210 is the first bad commit
commit 19b5050fbf6a61910ca145089042800211b93210
Author: Michael Jumper <mjum...@apache.org>
Date: Tue Feb 6 21:19:24 2018 -0800
GUACAMOLE-482: Fail overall encoding process if any instruction handler
reports failure.
:040000 040000 52f28b4a6ba200f9af1485d943965b9d54d86c78
6bae98d360d943dcf6890fc9f86dceb2f77978de M src
{code}
> Return value of guacenc_video_flush_frame() not handled
> -------------------------------------------------------
>
> Key: GUACAMOLE-482
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-482
> Project: Guacamole
> Issue Type: Bug
> Components: guacenc
> Affects Versions: 0.9.13-incubating
> Environment: using provided dockerfile build
> Reporter: Ryan Underwood
> Assignee: Michael Jumper
> Priority: Trivial
> Fix For: 1.0.0
>
>
> In this file:
> https://github.com/apache/guacamole-server/blob/master/src/guacenc/display-sync.c
> line 52, the function called "guacenc_video_advance_timeline" doesn't appear
> to have a path that can return 1.
> Reporting because I wasn't sure if this was an artifact from a refactor, a
> bug where guacenc_video_advance_timeline _should_ have a path that returns 1,
> or if it was just a bit of extra code that can go away.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
