Nick Couchman created GUACAMOLE-586:
---------------------------------------
Summary: RADIUS Relies on Default Character Set
Key: GUACAMOLE-586
URL: https://issues.apache.org/jira/browse/GUACAMOLE-586
Project: Guacamole
Issue Type: Bug
Affects Versions: 0.9.14
Reporter: Nick Couchman
Assignee: Nick Couchman
As reported by Coverity:
{quote}
________________________________________________________________________________________________________
*** CID 1428763: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING)
/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java:
100 in
org.apache.guacamole.auth.radius.AuthenticationProviderService.getRadiusChallenge(net.jradius.packet.RadiusPacket)()
94 logger.debug("Expecting a Attr_ReplyMessage attribute on this
packet, and did not get one.");
95 return null;
96 }
97
98 // We have the required attributes - convert to strings and then
generate the additional login box/field
99 String replyMsg = replyAttr.toString();
>>> CID 1428763: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING)
>>> Found reliance on default encoding: new String(byte[]).
100 String radiusState = new String(stateAttr.getValue().getBytes());
101 Field radiusResponseField = new
RadiusChallengeResponseField(replyMsg);
102 Field radiusStateField = new RadiusStateField(radiusState);
103
104 // Return the CredentialsInfo object that has the state and the
expected response.
105 return new
CredentialsInfo(Arrays.asList(radiusResponseField,radiusStateField));
{quote}
Encoding should be explicitly set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
