[
https://issues.apache.org/jira/browse/GUACAMOLE-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584820#comment-16584820
]
Nick Couchman commented on GUACAMOLE-605:
-----------------------------------------
First, per the contribution guidelines, make sure that your code:
* Follows the style guidelines: http://guacamole.apache.org/guac-style/
* Is properly documented with JavaDoc comments.
I've not participated in very many open source projects, but I've seen a decent
amount of code, and a lot of them are pretty relaxed about style and
documentation. Guacamole (and probably ASF in general) is not - we try very,
very hard to maintain consistent style and documentation across the code. The
more you have done in advance of a Pull Request, the quicker/easier the pull
request will go. It may seem nit-picky or trivial or dictatorial, but it is
tremendously valuable for readability and collaboration in a project like this.
For an authentication extension like this, here's what I would suggest:
# Make sure you have a Github.com account, and fork the
https://github.com/apache/guacamole-client repository.
# In your forked copy of the repository, create a branch with a name
descriptive of your extension
# Commit the changes for your extension to the new branch in your copy of the
repo. Remember, per the contribution guidelines, all commit messages need to
be tagged with this JIRA issue (GUACAMOLE-605: Your commit message here).
# Once all changes are committed, create a Pull Request against the Apache
Github repository.
# Prepare yourself for the review process. Your code will probably be reviewed
by more than one person, and it will be a pretty detailed review. There will
likely be several iterations of the reviewers requesting changes, you updating
the code and committing, and another review cycle.
Looking forward to seeing it - I think this will be a great addition to the
code!
> Guacamole-Morphia Extension for Extension Guacamole-MongoDB support
> -------------------------------------------------------------------
>
> Key: GUACAMOLE-605
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-605
> Project: Guacamole
> Issue Type: New Feature
> Reporter: Daniel Quirant
> Priority: Minor
>
> Extension implementation based on the existing ones of jdbc.
> Replacing the MyBatis persistence manager with Morphia.
> Mapping of entities in Morphia mode and adaptation of queries with criteria
> used by Morphia.
> Guacamole-MongoDB extension that uses the Guacamole-Morphia extension to
> access the MongoDB documents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
