[
https://issues.apache.org/jira/browse/GUACAMOLE-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303424#comment-15303424
]
ASF GitHub Bot commented on GUACAMOLE-39:
-----------------------------------------
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/11#discussion_r64854256
--- Diff: src/common-ssh/guac_ssh.c ---
@@ -274,19 +275,36 @@ static void guac_common_ssh_kbd_callback(const char
*name, int name_len,
}
+void ssh_client_error(bool abortOnError, guac_client* client,
guac_protocol_status status,
--- End diff --
The are a few issues here:
1. The other functions defined in this part of guacamole-server all have
the namespace/prefix `guac_common_ssh_`. Should be the same here.
2. If this is not used externally (and not declared in a header file), it
should be `static`.
3. Documentation of the function and its parameters is missing.
4. The variable `abortOnError` does not follow the naming style of the rest
of this file or guacamole-server. Please user lowercase, separating words by
underscores.
As a minor nitpick, it's strange to me to a flag variable as the first
argument in a function. Normally such things are toward the end of the
parameter list. As this is essentially a selective wrapper for
`guac_client_abort()` and `guac_client_log()`, I would recommend following the
same ordering to avoid confusion when people try to develop against this in the
future.
I also notice that the `status` parameter is ignored in the case that the
abort flag is set. I don't immediately see a way to avoid that with this
approach, but perhaps that is a sign that a different approach would be better.
> If the VNC parameter enable-sftp is set to true but the SFTP server is not
> connectable, the system can not be accessed with VNC
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GUACAMOLE-39
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-39
> Project: Guacamole
> Issue Type: Bug
> Components: RDP, SSH, VNC
> Affects Versions: 0.9.9
> Reporter: Michael Jumper
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from
> [GUAC-1509|https://glyptodon.org/jira/browse/GUAC-1509], an issue in the JIRA
> instance used by the Guacamole project prior to its acceptance into the
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance
> *have not been copied* and can be found instead at the original issue.
> {panel}
> If a connection is configured to have SFTP support for file transfers with
> VNC, and the SFTP server goes down or is not connectable for any reason, the
> system can not be accessed. The Home, Reconnect, Logout dialog is displayed.
> From the guacd log:
> {code:none}
> Mar 3 10:20:25 guacd-server guacd[18646]: Protocol "vnc" selected
> Mar 3 10:20:25 guacd-server guacd[18646]: Connection ID is
> "$7ee12ae4-2a1d-4d4a-994c-ea2a4c4f9c02"
> Mar 3 10:20:25 guacd-server guacd[18646]: VNC server supports protocol
> version 3.8 (viewer 3.8)
> Mar 3 10:20:25 guacd-server guacd[18646]: We have 1 security types to read
> Mar 3 10:20:25 guacd-server guacd[18646]: 0) Received security type 2
> Mar 3 10:20:25 guacd-server guacd[18646]: Selecting security type 2 (0/1 in
> the list)
> Mar 3 10:20:25 guacd-server guacd[18646]: Selected Security Scheme 2
> Mar 3 10:20:25 guacd-server guacd[18646]: VNC authentication succeeded
> Mar 3 10:20:25 guacd-server guacd[18646]: Desktop name "Windows8"
> Mar 3 10:20:25 guacd-server guacd[18646]: Connected to VNC server, using
> protocol version 3.8
> Mar 3 10:20:25 guacd-server guacd[18646]: VNC server default format:
> Mar 3 10:20:25 guacd-server guacd[18646]: 32 bits per pixel.
> Mar 3 10:20:25 guacd-server guacd[18646]: Least significant byte first in
> each pixel.
> Mar 3 10:20:25 guacd-server guacd[18646]: TRUE colour: max red 255 green
> 255 blue 255, shift red 16 green 8 blue 0
> Mar 3 10:20:28 guacd-server guacd[18646]: Unable to connect to any addresses.
> Mar 3 10:20:28 guacd-server guacd[18646]: Connection did not succeed
> {code}
> From the guacamole log:
> {code:none}
> 10:20:28.502 [http-bio-8081-exec-3] INFO
> o.g.g.net.basic.TunnelRequestService - User "admin" connected to connection
> "sftptest".
> 10:20:28.515 [http-bio-8081-exec-3] INFO
> o.g.g.net.basic.TunnelRequestService - User "admin" disconnected from
> connection "sftptest". Duration: 13 milliseconds
> {code}
> If the enable-sftp param is changed to false, or deleted, this connection
> succeeds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
