GUACAMOLE-136: Use hidden submit button for submitting Duo response (form.submit() inserts query parameters and causes browser navigation, despite ngSubmit preventing default).
Project: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/commit/548966ae Tree: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/tree/548966ae Diff: http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/diff/548966ae Branch: refs/heads/master Commit: 548966ae5a9bfc8ba574d977bbccad482d036702 Parents: 48af3ef Author: Michael Jumper <[email protected]> Authored: Thu Dec 1 21:33:28 2016 -0800 Committer: Michael Jumper <[email protected]> Committed: Mon Dec 5 22:19:45 2016 -0800 ---------------------------------------------------------------------- .../main/resources/controllers/duoSignedResponseController.js | 2 +- extensions/guacamole-auth-duo/src/main/resources/styles/duo.css | 4 ++++ .../src/main/resources/templates/duoSignedResponseField.html | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/blob/548966ae/extensions/guacamole-auth-duo/src/main/resources/controllers/duoSignedResponseController.js ---------------------------------------------------------------------- diff --git a/extensions/guacamole-auth-duo/src/main/resources/controllers/duoSignedResponseController.js b/extensions/guacamole-auth-duo/src/main/resources/controllers/duoSignedResponseController.js index 0d10f8e..f683698 100644 --- a/extensions/guacamole-auth-duo/src/main/resources/controllers/duoSignedResponseController.js +++ b/extensions/guacamole-auth-duo/src/main/resources/controllers/duoSignedResponseController.js @@ -56,7 +56,7 @@ angular.module('guacDuo').controller('duoSignedResponseController', ['$scope', }); // Submit updated credentials - $(iframe).parents('form').submit(); + $('.duo-signature-response-field input[type="submit"]').click(); }; http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/blob/548966ae/extensions/guacamole-auth-duo/src/main/resources/styles/duo.css ---------------------------------------------------------------------- diff --git a/extensions/guacamole-auth-duo/src/main/resources/styles/duo.css b/extensions/guacamole-auth-duo/src/main/resources/styles/duo.css index 36d6031..db49ab3 100644 --- a/extensions/guacamole-auth-duo/src/main/resources/styles/duo.css +++ b/extensions/guacamole-auth-duo/src/main/resources/styles/duo.css @@ -17,6 +17,10 @@ * under the License. */ +.duo-signature-response-field input[type="submit"] { + display: none !important; +} + .duo-signature-response-field iframe { width: 100%; max-width: 620px; http://git-wip-us.apache.org/repos/asf/incubator-guacamole-client/blob/548966ae/extensions/guacamole-auth-duo/src/main/resources/templates/duoSignedResponseField.html ---------------------------------------------------------------------- diff --git a/extensions/guacamole-auth-duo/src/main/resources/templates/duoSignedResponseField.html b/extensions/guacamole-auth-duo/src/main/resources/templates/duoSignedResponseField.html index 4658ed0..622bd42 100644 --- a/extensions/guacamole-auth-duo/src/main/resources/templates/duoSignedResponseField.html +++ b/extensions/guacamole-auth-duo/src/main/resources/templates/duoSignedResponseField.html @@ -1,3 +1,4 @@ <div class="duo-signature-response-field" ng-class="{ loading : !duoInterfaceLoaded }"> <iframe></iframe> + <input type="submit"> </div>
