[
https://issues.apache.org/jira/browse/GUACAMOLE-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745031#comment-15745031
]
wangxh commented on GUACAMOLE-139:
----------------------------------
I did not express clearly. This is a logical error.
In function __guac_common_surface_should_use_webp(), the return is framerate
>= GUAC_COMMON_SURFACE_JPEG_FRAMERATE &&
__guac_common_surface_png_optimality(surface, rect) < 0.
In function __guac_common_surface_should_use_jpeg(), the return is framerate
>= GUAC_COMMON_SURFACE_JPEG_FRAMERATE && rect_size >
GUAC_SURFACE_JPEG_MIN_BITMAP_SIZE &&
__guac_common_surface_png_optimality(surface, rect) < 0
If the first function returns 1, guacd use WebP. If the first returns 0, the
second also returns 0. So guacd will not use JPEG.
> guacd cannot transfer pictures as JPEG
> --------------------------------------
>
> Key: GUACAMOLE-139
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-139
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 0.9.9
> Environment: Ubuntu 16.04 LTS
> Reporter: wangxh
>
> When guacd judge which is better choice(jpeg webp png), JPEG will nerver
> available. JPEG's judgment should be in front of webp's judgment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
