[ 
https://issues.apache.org/jira/browse/GUACAMOLE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tyler Schneider updated GUACAMOLE-229:
--------------------------------------
    Description: 
Tunnel.js' mechanism to fall back to polling when onreadystate doesn't work 
won't clear the intervals in certain conditions.  The commit 
627271953d6eee6f49f4a385d8de62d6a0098be5 accidentally changed the functionality 
of some conditions, causing 2 of the 3 clearIntervals to never clear an 
existing interval.  My suspicion is that, on stock guacamole, it won't actually 
be doing much (just figuring out the message is already done parsing), but it 
still fires every 30ms until the socket closes.

Pull request: https://github.com/apache/incubator-guacamole-client/pull/126

  was:
Tunnel.js' mechanism to fall back to polling when onreadystate doesn't work 
won't clear the intervals in certain conditions.  The commit 
627271953d6eee6f49f4a385d8de62d6a0098be5 accidentally changed the functionality 
of some conditions, causing 2 of the 3 clearIntervals to never clear an 
existing interval.  My suspicion is that, on stock guacamole, it won't actually 
be doing much (just figuring out the message is already done parsing), but it 
still fires every 30ms until the socket closes.

I will submit a pull request for it when I can.


> Intervals when polling xmlhttprequests are not always cleared
> -------------------------------------------------------------
>
>                 Key: GUACAMOLE-229
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-229
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-common-js
>            Reporter: Tyler Schneider
>            Priority: Minor
>
> Tunnel.js' mechanism to fall back to polling when onreadystate doesn't work 
> won't clear the intervals in certain conditions.  The commit 
> 627271953d6eee6f49f4a385d8de62d6a0098be5 accidentally changed the 
> functionality of some conditions, causing 2 of the 3 clearIntervals to never 
> clear an existing interval.  My suspicion is that, on stock guacamole, it 
> won't actually be doing much (just figuring out the message is already done 
> parsing), but it still fires every 30ms until the socket closes.
> Pull request: https://github.com/apache/incubator-guacamole-client/pull/126



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to