[ 
https://issues.apache.org/jira/browse/GUACAMOLE-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066428#comment-16066428
 ] 

Mark Goldey edited comment on GUACAMOLE-205 at 6/28/17 12:46 PM:
-----------------------------------------------------------------

I am finally getting around to trying to build Guacamole again, but I'm seeing 
the same error in 0.9.12:

{code:none}
Making install in src/common-ssh
make[1]: Entering directory 
'/home/mark/guacamole-server-0.9.12-incubating/src/common-ssh'
  CC       libguac_common_ssh_la-ssh.lo
ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but not used 
[-Werror=unused-function]
 static unsigned long guac_common_ssh_openssl_id_callback() {
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but not 
used [-Werror=unused-function]
 static void guac_common_ssh_openssl_locking_callback(int mode, int n,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:488: recipe for target 'libguac_common_ssh_la-ssh.lo' failed
make[1]: Leaving directory 
'/home/mark/guacamole-server-0.9.12-incubating/src/common-ssh'
Makefile:494: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1
root@faf2:/home/mark/guacamole-server-0.9.12-incubating# 
{code}

Should this be fixed in 0.9.12?  If not any suggestions for a successful build? 
 Commenting out the two functions as suggested results in the error shown 
above.  I'm not enough of a guru to think of other solutions.

Thanks.


was (Author: mgoldey):
I am finally getting around to trying to build Guacamole again, but I'm seeing 
the same error in 0.9.12:

{code:none}
Making install in src/common-ssh
make[1]: Entering directory 
'/home/mark/guacamole-server-0.9.12-incubating/src/common-ssh'
  CC       libguac_common_ssh_la-ssh.lo
ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but not used 
[-Werror=unused-function]
 static unsigned long guac_common_ssh_openssl_id_callback() {
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined but not 
used [-Werror=unused-function]
 static void guac_common_ssh_openssl_locking_callback(int mode, int n,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:488: recipe for target 'libguac_common_ssh_la-ssh.lo' failed
{code}

Should this be fixed in 0.9.12?  If not any suggestions for a successful build? 
 Commenting out the two functions as suggested results in the error shown 
above.  I'm not enough of a guru to think of other solutions.

Thanks.

> libguac_common_ssh build fails with OpenSSL 1.1
> -----------------------------------------------
>
>                 Key: GUACAMOLE-205
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-205
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-server, SSH
>    Affects Versions: 0.9.11-incubating
>         Environment: Linux 4.9.0-1-686-pae #1 SMP Debian 4.9.2-2 (2017-01-12) 
> i686 GNU/Linux
>            Reporter: Mark Goldey
>            Assignee: Michael Jumper
>             Fix For: 0.9.13-incubating
>
>
> There are a number of changes in OpenSSL 1.1 which break compatibility with 
> older versions of the API, and which break the Guacamole build if OpenSSL 1.1 
> is present, particularly the removal of threading callbacks (replaced with 
> no-op macros) and the migration to opaque structures with public accessor 
> functions. The error below is due to the no-op macros, and fixing those 
> reveals further errors due to the new and required public accessor functions.
> A rough list is here:
> https://wiki.openssl.org/index.php/1.1_API_Changes
> The Guacamole build will need to be updated to take these changes into 
> account. The original issue report:
> {quote}
> I have compiled and used guacamole since v. 9.8 or so.  I just downloaded the 
> source for 9.11-incubating.  ./configure works fine.  Make terminates with 
> the following error:
> {code:none}
> make[2]: Entering directory 
> '/home/xxx/guacamole-server-0.9.11-incubating/src/common-ssh'
>   CC       libguac_common_ssh_la-guac_sftp.lo
>   CC       libguac_common_ssh_la-guac_ssh.lo
> guac_ssh.c:89:22: error: ‘guac_common_ssh_openssl_id_callback’ defined but 
> not used [-Werror=unused-function]
>  static unsigned long guac_common_ssh_openssl_id_callback() {
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> guac_ssh.c:70:13: error: ‘guac_common_ssh_openssl_locking_callback’ defined 
> but not used [-Werror=unused-function]
>  static void guac_common_ssh_openssl_locking_callback(int mode, int n,
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> Makefile:479: recipe for target 'libguac_common_ssh_la-guac_ssh.lo' failed
> make[2]: *** [libguac_common_ssh_la-guac_ssh.lo] Error 1
> make[2]: Leaving directory 
> '/home/mark/guacamole-server-0.9.11-incubating/src/common-ssh'
> Makefile:486: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/home/xxx/guacamole-server-0.9.11-incubating'
> Makefile:418: recipe for target 'all' failed
> make: *** [all] Error 2
> {code}
> Make files is not my strong suit, but it seems like there's a problem with 
> the configure script?
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to