[
https://issues.apache.org/jira/browse/GUACAMOLE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208786#comment-16208786
]
Michael Jumper commented on GUACAMOLE-419:
------------------------------------------
Attempting to reproduce this, I created an extension ([^guacamole-419.jar])
which only overrides the section header in question using the following
{{en.json}}:
{code:none}
{
"CONNECTION_ATTRIBUTES" : {
"SECTION_HEADER_GUACD" : "Different Header"
}
}
{code}
Adding both that extension and the PostgreSQL extension to
{{GUACAMOLE_HOME/extensions/}} (and turning on debug-level logging), Guacamole
logs that the translation overlays are applied:
{code:none}
DEBUG o.a.g.extension.ExtensionModule - [1] Binding AuthenticationProvider
"org.apache.guacamole.auth.postgresql.PostgreSQLSharedAuthenticationProvider".
DEBUG o.a.g.e.LanguageResourceService - Merged strings with existing language:
"ru"
DEBUG o.a.g.e.LanguageResourceService - Merged strings with existing language:
"fr"
DEBUG o.a.g.e.LanguageResourceService - Merged strings with existing language:
"en"
INFO o.a.g.extension.ExtensionModule - Extension "PostgreSQL Authentication"
loaded.
DEBUG o.a.g.extension.ExtensionModule - Loading extension: "guacamole-419.jar"
DEBUG o.a.g.e.LanguageResourceService - Merged strings with existing language:
"en"
INFO o.a.g.extension.ExtensionModule - Extension "Attempt to reproduce
GUACAMOLE-419" loaded.
{code}
Editing a connection defined within PostgreSQL, the header content has indeed
been overridden:
!overridden-header-text.png!
Extensions are loaded in sorted order. If you're not seeing your overidden
string appear, please verify:
# Your extension sorts last filename-wise within
{{GUACAMOLE_HOME/extensions/}}, or at least sorts after the extension(s) you're
attempting to override.
# The old translation strings are not cached by the browser.
{quote}
It seems like there needs to be a way to allow all text with the settings pages
to be customized even if they are part of another extension... especially a
built in one.
{quote}
Extensions are by definition not built-in. I get what you're trying to say
here, but I want to point out that being part of the mainline guacamole-client
source tree doesn't actually result in the extension being treated differently
by the webapp compared to any other extension. When the webapp starts up, it
loads all extensions in order and identically.
> Can't override language file for a built in extension via translation file in
> custom extension
> ----------------------------------------------------------------------------------------------
>
> Key: GUACAMOLE-419
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-419
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Reporter: Fred Kenowski
> Priority: Minor
> Attachments: guacamole-419.jar, guaproxy.jpg,
> overridden-header-text.png
>
>
> Go to the connection settings page as shown in the screenshot below. Notice,
> the section that says "Guacamole Proxy Parameters".
> (1) If you change languages, you'll notice this section does not change
> because the guacamole-auth-jdbc extension only contains an en.json file.
> (2) If you try to create a custom extension and override the
> "CONNECTION_ATTRIBUTES" section from the guacamole-auth-jdbc extension, it
> won't pick up.
> It seems like there needs to be a way to allow all text with the settings
> pages to be customized even if they are part of another extension...
> especially a built in one.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
