This is an automated email from the ASF dual-hosted git repository.

skrawcz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hamilton.git

commit 58ccfbaefc0f05e4887076303f1ded632e229c98
Author: Stefan Krawczyk <[email protected]>
AuthorDate: Tue Feb 24 00:03:21 2026 -0800

    Fix SDK CI to use hamilton from source instead of PyPI
    
    The SDK tests were installing hamilton from PyPI which didn't include
    the latest pandas_extensions.py fixes, causing tests to fail with:
    TypeError: read_csv() got an unexpected keyword argument 'verbose'
    
    Problem:
    The workflow was doing:
    1. pip install -e ${{ github.workspace }}  (installs hamilton from source)
    2. pip install -r requirements.txt          (has sf-hamilton>=1.43.0, 
overwrites!)
    
    Solution:
    Reorder to install hamilton from source AFTER requirements.txt:
    1. pip install -r requirements.txt          (installs PyPI version)
    2. pip install -e ${{ github.workspace }}  (overwrites with source - 
includes fixes)
    
    This ensures SDK tests run against the current source code, catching
    issues before they reach production.
    
    Related: https://github.com/apache/hamilton/actions/runs/22341206798
---
 ui/sdk/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/sdk/requirements.txt b/ui/sdk/requirements.txt
index 1b8ca288..c21ff08d 100644
--- a/ui/sdk/requirements.txt
+++ b/ui/sdk/requirements.txt
@@ -5,5 +5,5 @@ jinja2 # for SDK, todo -- move out
 loguru # for init, todo -- move out
 posthog
 requests
-sf-hamilton>=1.43.0
+# sf-hamilton>=1.43.0
 sqlglot

Reply via email to