Repository: incubator-hawq
Updated Branches:
  refs/heads/HAWQ-992 c2ff7ad65 -> 9936fc225


HAWQ-992. Added Javadocs.


Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/9936fc22
Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/9936fc22
Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/9936fc22

Branch: refs/heads/HAWQ-992
Commit: 9936fc2254be0feb503b7b25ef172e2f31469b34
Parents: c2ff7ad
Author: Oleksandr Diachenko <[email protected]>
Authored: Wed Sep 7 13:53:37 2016 -0700
Committer: Oleksandr Diachenko <[email protected]>
Committed: Wed Sep 7 13:53:37 2016 -0700

----------------------------------------------------------------------
 .../pxf/plugins/hive/utilities/HiveUtilities.java    | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/9936fc22/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
----------------------------------------------------------------------
diff --git 
a/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
 
b/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
index 1d928ba..6abb5ba 100644
--- 
a/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
+++ 
b/pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/HiveUtilities.java
@@ -276,7 +276,20 @@ public class HiveUtilities {
 
 
     /**
-     * Validates whether given HAWQ and Hive data types are compatible
+     * Validates whether given HAWQ and Hive data types are compatible.
+     * If data type could have modifiers, HAWQ data type is valid if it hasn't 
modifiers at all
+     * or HAWQ's modifiers are greater or equal to Hive's modifiers.
+     * <p>
+     * For example:
+     * <p>
+     * Hive type - varchar(20), HAWQ type varchar - valid.
+     * <p>
+     * Hive type - varchar(20), HAWQ type varchar(20) - valid.
+     * <p>
+     * Hive type - varchar(20), HAWQ type varchar(25) - valid.
+     * <p>
+     * Hive type - varchar(20), HAWQ type varchar(15) - invalid.
+     *
      *
      * @param hawqDataType HAWQ data type
      * @param hawqTypeMods HAWQ type modifiers

Reply via email to