Repository: incubator-hawq Updated Branches: refs/heads/master b282aef2e -> 5f972f9be
HAWQ-1529. Fix segment resource manager hang when postmaster died. If PostmasterIsAlive() is under implicit declaration, %eax (32-bits) will be used for comparison rather than %al (8-bits), BUT PostmasterIsAlive() only set the lower 8-bits (because 'bool' is really a 'char'). Then segment resource manager will never exit after postmaster died. Project: http://git-wip-us.apache.org/repos/asf/incubator-hawq/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-hawq/commit/5f972f9b Tree: http://git-wip-us.apache.org/repos/asf/incubator-hawq/tree/5f972f9b Diff: http://git-wip-us.apache.org/repos/asf/incubator-hawq/diff/5f972f9b Branch: refs/heads/master Commit: 5f972f9bef14ec15c5da6d868993a2108d2d9e22 Parents: b282aef Author: Kuien Liu <[email protected]> Authored: Mon Sep 25 16:40:54 2017 +0800 Committer: Wen Lin <[email protected]> Committed: Tue Sep 26 09:21:21 2017 +0800 ---------------------------------------------------------------------- src/backend/resourcemanager/resourcemanager_RMSEG.c | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-hawq/blob/5f972f9b/src/backend/resourcemanager/resourcemanager_RMSEG.c ---------------------------------------------------------------------- diff --git a/src/backend/resourcemanager/resourcemanager_RMSEG.c b/src/backend/resourcemanager/resourcemanager_RMSEG.c index f8afe5a..ae83f45 100644 --- a/src/backend/resourcemanager/resourcemanager_RMSEG.c +++ b/src/backend/resourcemanager/resourcemanager_RMSEG.c @@ -27,6 +27,7 @@ #include "communication/rmcomm_RMSEG2RM.h" #include "resourceenforcer/resourceenforcer.h" #include "cdb/cdbtmpdir.h" +#include "storage/pmsignal.h" /* PostmasterIsAlive */ int ResManagerMainSegment2ndPhase(void) {
