svn commit: r1228738 - in /hbase/branches/0.92: CHANGES.txt src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java

[stack]

Author: stack
Date: Sat Jan  7 22:15:47 2012
New Revision: 1228738

URL: http://svn.apache.org/viewvc?rev=1228738&view=rev
Log:
HBASE-5141 Memory leak in MonitoredRPCHandlerImpl

Modified:
    hbase/branches/0.92/CHANGES.txt
    
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
    
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java

Modified: hbase/branches/0.92/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/hbase/branches/0.92/CHANGES.txt?rev=1228738&r1=1228737&r2=1228738&view=diff
==============================================================================
--- hbase/branches/0.92/CHANGES.txt (original)
+++ hbase/branches/0.92/CHANGES.txt Sat Jan  7 22:15:47 2012
@@ -509,6 +509,7 @@ Release 0.92.0 - Unreleased
    HBASE-5081  Distributed log splitting deleteNode races against splitLog 
retry (Prakash)
    HBASE-4357  Region stayed in transition - in closing state (Ming Ma)
    HBASE-5088  A concurrency issue on SoftValueSortedMap (Jieshan Bean and 
Lars H)
+   HBASE-5141  Memory leak in MonitoredRPCHandlerImpl
 
   TESTS
    HBASE-4492  TestRollingRestart fails intermittently

Modified: 
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
URL: 
http://svn.apache.org/viewvc/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java?rev=1228738&r1=1228737&r2=1228738&view=diff
==============================================================================
--- 
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 
(original)
+++ 
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 
Sat Jan  7 22:15:47 2012
@@ -1343,6 +1343,7 @@ public abstract class HBaseServer implem
                 errorClass, error);
           }
           call.sendResponseIfReady();
+          status.markComplete("Sent response");
         } catch (InterruptedException e) {
           if (running) {                          // unexpected -- log it
             LOG.info(getName() + " caught: " +

Modified: 
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
URL: 
http://svn.apache.org/viewvc/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java?rev=1228738&r1=1228737&r2=1228738&view=diff
==============================================================================
--- 
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
 (original)
+++ 
hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
 Sat Jan  7 22:15:47 2012
@@ -217,6 +217,13 @@ public class MonitoredRPCHandlerImpl ext
     this.remotePort = remotePort;
   }
 
+  @Override
+  public void markComplete(String status) {
+    super.markComplete(status);
+    this.params = null;
+    this.packet = null;
+  }
+
   public synchronized Map<String, Object> toMap() {
     // only include RPC info if the Handler is actively servicing an RPC call
     Map<String, Object> map = super.toMap();