This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2 by this push:
new ad2d1e775e0 HBASE-28512 Update error prone to 2.26.1 (#5844)
ad2d1e775e0 is described below
commit ad2d1e775e0d55d121ad6ceb4db66150355d25e7
Author: Duo Zhang <zhang...@apache.org>
AuthorDate: Fri Apr 26 13:57:56 2024 +0800
HBASE-28512 Update error prone to 2.26.1 (#5844)
Signed-off-by: Xin Sun <ddu...@gmail.com>
---
.../src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java | 3 ++-
.../java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java | 2 +-
.../org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java | 2 +-
pom.xml | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git
a/hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java
b/hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java
index e5835fd65b6..0fe46194083 100644
--- a/hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java
+++ b/hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java
@@ -20,6 +20,7 @@ package org.apache.hadoop.hbase.http;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import javax.servlet.http.HttpServletRequest;
@@ -94,7 +95,7 @@ public class TestHtmlQuoting {
quoter.getParameterValues("x"));
Mockito.doReturn(null).when(mockReq).getParameterValues("x");
- assertArrayEquals("Test that missing parameters dont cause NPE for array",
null,
+ assertNull("Test that missing parameters dont cause NPE for array",
quoter.getParameterValues("x"));
}
}
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
index 80d38677237..5fd3186a0c1 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
@@ -311,7 +311,7 @@ public class TestHRegionInfo {
b = new HRegionInfo(t.getTableName(), midway, null);
assertTrue(a.compareTo(b) < 0);
assertTrue(b.compareTo(a) > 0);
- assertEquals(a, a);
+ assertTrue(a.equals(a));
assertEquals(0, a.compareTo(a));
a = new HRegionInfo(t.getTableName(), Bytes.toBytes("a"),
Bytes.toBytes("d"));
b = new HRegionInfo(t.getTableName(), Bytes.toBytes("e"),
Bytes.toBytes("g"));
diff --git
a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
index 0c44d869d91..7607a6a5a23 100644
---
a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
+++
b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
@@ -518,7 +518,7 @@ public class TestThriftHBaseServiceHandler {
get = new TGet(wrap(rowName));
result = handler.get(table, get);
- assertArrayEquals(null, result.getRow());
+ assertNull(result.getRow());
assertEquals(0, result.getColumnValuesSize());
}
diff --git a/pom.xml b/pom.xml
index e0e838eec04..bb3bc9d8601 100644
--- a/pom.xml
+++ b/pom.xml
@@ -634,7 +634,7 @@
-->
<checkstyle.version>8.29</checkstyle.version>
<exec.maven.version>3.1.0</exec.maven.version>
- <error-prone.version>2.16</error-prone.version>
+ <error-prone.version>2.26.1</error-prone.version>
<jamon.plugin.version>2.4.2</jamon.plugin.version>
<lifecycle.mapping.version>1.0.0</lifecycle.mapping.version>
<maven.antrun.version>1.8</maven.antrun.version>
