This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 670deaa1d60 HBASE-29040 Fix description of "sampleRate" of 
PerformanceEvaluation (#6558)
670deaa1d60 is described below

commit 670deaa1d6020b1f603819504f95e016c1e06dbb
Author: Junegunn Choi <[email protected]>
AuthorDate: Mon Jan 13 20:41:00 2025 +0900

    HBASE-29040 Fix description of "sampleRate" of PerformanceEvaluation (#6558)
    
    Signed-off-by: Duo Zhang <[email protected]>
---
 .../src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
 
b/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
index 9698ae9376e..876a2640054 100644
--- 
a/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
+++ 
b/hbase-diagnostics/src/main/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
@@ -1196,7 +1196,7 @@ public class PerformanceEvaluation extends Configured 
implements Tool {
       this.opts = options;
       this.status = status;
       this.testName = this.getClass().getSimpleName();
-      everyN = (long) (opts.totalRows / (opts.totalRows * opts.sampleRate));
+      everyN = (long) (1 / opts.sampleRate);
       if (options.isValueZipf()) {
         this.zipf =
           new RandomDistribution.Zipf(ThreadLocalRandom.current(), 1, 
options.getValueSize(), 1.2);
@@ -2699,8 +2699,7 @@ public class PerformanceEvaluation extends Configured 
implements Tool {
       + "Default: depend on oneCon parameter. if oneCon set to true, then 
connCount=1, "
       + "if not, connCount=thread number");
 
-    System.err.println(" sampleRate      Execute test on a sample of total "
-      + "rows. Only supported by randomRead. Default: 1.0");
+    System.err.println(" sampleRate      Execute test on a sample of total 
rows. Default: 1.0");
     System.err.println(" period          Report every 'period' rows: "
       + "Default: opts.perClientRunRows / 10 = " + 
DEFAULT_OPTS.getPerClientRunRows() / 10);
     System.err.println(" cycles          How many times to cycle the test. 
Defaults: 1.");

Reply via email to