(hbase) branch branch-2.5 updated: HBASE-29093 Load userSnapshots.jsp only on master status page (#6696)

[psomogyi]

This is an automated email from the ASF dual-hosted git repository.

psomogyi pushed a commit to branch branch-2.5
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.5 by this push:
     new 5d1235eba7e HBASE-29093 Load userSnapshots.jsp only on master status 
page (#6696)
5d1235eba7e is described below

commit 5d1235eba7e662b8ace62e7b12c478f554635090
Author: Dávid Paksy <paksyda...@gmail.com>
AuthorDate: Fri Feb 28 14:21:01 2025 +0100

    HBASE-29093 Load userSnapshots.jsp only on master status page (#6696)
    
    Before HBase UI always tried to load `userSnapshots.jsp` with an AJAX 
request on all UI pages - **NOK**.
    
    This happened even on RegionServer UI or REST UI where this call always 
failed with HTTP 500.
    
    From now on HBase UI only loads `userSnapshots.jsp` when the Snapshots tab 
(div with `tab_userSnapshots` ID) exists on the page.
    
    Also did a minor improvement to `tab.js`: use `const` instead of `var` as 
`var` has so many problems:
    > With block-level scope, no hoisting, and the ability to declare 
constants, let and const make code more predictable, maintainable, and less 
error-prone. By using let and const instead of var, developers can avoid common 
pitfalls and write more declarative code.
    
    Also fixed a whitespace.
    
    Signed-off-by: Duo Zhang <zhang...@apache.org>
    Signed-off-by: Nihal Jain <nihalj...@apache.org
    Signed-off-by: Peter Somogyi <psomo...@apache.org
---
 .../src/main/resources/hbase-webapps/static/js/tab.js  | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/hbase-server/src/main/resources/hbase-webapps/static/js/tab.js 
b/hbase-server/src/main/resources/hbase-webapps/static/js/tab.js
index 808882b9f40..1e54f6614bd 100644
--- a/hbase-server/src/main/resources/hbase-webapps/static/js/tab.js
+++ b/hbase-server/src/main/resources/hbase-webapps/static/js/tab.js
@@ -20,19 +20,23 @@
 
 $(document).ready(
   function(){
-    var prefix = "tab_";
-       $('.tabbable .nav-pills a').click(function (e) {
+    const prefix = "tab_";
+    $('.tabbable .nav-pills a').click(function (e) {
         e.preventDefault();
         location.hash = $(e.target).attr('href').substr(1).replace(prefix, "");
         $(this).tab('show');
     });
 
-  $.ajax({url:"/userSnapshots.jsp", success:function(result){
-    $("#tab_userSnapshots").html(result);
-  }});
-            
+    const $userSnapshotsTab = $("#tab_userSnapshots");
+    const isUserSnapshotsTabExists = $userSnapshotsTab.length;
+    if (isUserSnapshotsTabExists) {
+      $.ajax({url:"/userSnapshots.jsp", success:function(result){
+        $userSnapshotsTab.html(result);
+      }});
+    }
+
     if (location.hash !== '') {
-      var tabItem = $('a[href="' + location.hash.replace("#", "#"+prefix) + 
'"]');
+      const tabItem = $('a[href="' + location.hash.replace("#", "#"+prefix) + 
'"]');
       tabItem.tab('show');
       $(document).scrollTop(0);  
       return false;