This is an automated email from the ASF dual-hosted git repository. wchevreuil pushed a commit to branch HBASE-29427 in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 316da78dac227f4dc8313147c95d89e90bae42bd Author: Wellington Ramos Chevreuil <[email protected]> AuthorDate: Thu Jul 10 11:02:54 2025 +0100 addressing javadoc, checkstyle and spotless issues Change-Id: I49d287cddf81170514474b27a642c249a7bc79d7 --- .../java/org/apache/hadoop/hbase/io/hfile/BlockCache.java | 6 +++--- .../hbase/regionserver/compactions/CustomCellTieredUtils.java | 3 +++ .../hbase/regionserver/TestCustomCellDataTieringManager.java | 11 ++++++----- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java index be3f8beb454..9297e7074a9 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java @@ -213,9 +213,9 @@ public interface BlockCache extends Iterable<CachedBlock>, ConfigurationObserver * not be overridden by all implementing classes. In such cases, the returned Optional will be * empty. For subclasses implementing this logic, the returned Optional would contain the boolean * value reflecting if the passed block should indeed be cached. - * @param key The key representing the block to check if it should be cached. - * @param timeRangeTracker the time range tracker containing the timestamps - * @param conf The configuration object to use for determining caching behavior. + * @param key The key representing the block to check if it should be cached. + * @param maxTimeStamp The maximum timestamp for the block to check if it should be cached. + * @param conf The configuration object to use for determining caching behavior. * @return An empty Optional if this method is not supported; otherwise, the returned Optional * contains the boolean value indicating if the block should be cached. */ diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CustomCellTieredUtils.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CustomCellTieredUtils.java index 538cbda2f3f..f908b31e4ae 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CustomCellTieredUtils.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CustomCellTieredUtils.java @@ -28,6 +28,9 @@ import org.apache.yetus.audience.InterfaceAudience; @InterfaceAudience.Private public class CustomCellTieredUtils { + private CustomCellTieredUtils() { + // Utility class, no instantiation + } public static void checkForModifyTable(TableDescriptor newTable) throws IOException { for (ColumnFamilyDescriptor descriptor : newTable.getColumnFamilies()) { diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellDataTieringManager.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellDataTieringManager.java index 454c0528790..b01717dfa1f 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellDataTieringManager.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellDataTieringManager.java @@ -19,7 +19,6 @@ package org.apache.hadoop.hbase.regionserver; import static org.apache.hadoop.hbase.HConstants.BUCKET_CACHE_SIZE_KEY; import static org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.DEFAULT_ERROR_TOLERATION_DURATION; -import static org.apache.hadoop.hbase.regionserver.TestDataTieringManager.createHStoreFile; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; @@ -81,12 +80,14 @@ import org.slf4j.LoggerFactory; * This class is used to test the functionality of the DataTieringManager. * * The mock online regions are stored in {@link TestCustomCellDataTieringManager#testOnlineRegions}. - * For all tests, the setup of {@link TestCustomCellDataTieringManager#testOnlineRegions} occurs only once. + * For all tests, the setup of + * {@link TestCustomCellDataTieringManager#testOnlineRegions} occurs only once. * Please refer to {@link TestCustomCellDataTieringManager#setupOnlineRegions()} for the structure. - * Additionally, a list of all store files is maintained in {@link TestCustomCellDataTieringManager#hStoreFiles}. + * Additionally, a list of all store files is + * maintained in {@link TestCustomCellDataTieringManager#hStoreFiles}. * The characteristics of these store files are listed below: - * @formatter:off ## HStoreFile Information - * + * @formatter:off + * ## HStoreFile Information * | HStoreFile | Region | Store | DataTiering | isHot | * |------------------|--------------------|---------------------|-----------------------|-------| * | hStoreFile0 | region1 | hStore11 | CUSTOM_CELL_VALUE | true |
