This is an automated email from the ASF dual-hosted git repository.

liuxiaocs7 pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 78cea40bfe4 HBASE-30273 Backport HBASE-26107 MOB compaction with 
missing files catches incorrect exception to branch-2.x (#8449)
78cea40bfe4 is described below

commit 78cea40bfe4441b961709cfab7a614bc7f382a35
Author: Xiao Liu <[email protected]>
AuthorDate: Fri Jul 3 11:48:03 2026 +0800

    HBASE-30273 Backport HBASE-26107 MOB compaction with missing files catches 
incorrect exception to branch-2.x (#8449)
    
    (cherry picked from commit 3c70bc1f312bd2a833d408c3af82731e5fee66ea)
    
    Signed-off-by: Duo Zhang <[email protected]>
    Signed-off-by: Pankaj Kumar <[email protected]>
    Signed-off-by: Peter Somogyi <[email protected]>
    Co-authored-by: Peter Somogyi <[email protected]>
---
 .../apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java    | 10 +++++++---
 .../org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java | 12 ++++++++----
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
index f4817ab9226..daa1d703865 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
@@ -35,6 +35,7 @@ import org.apache.hadoop.fs.FileStatus;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.DoNotRetryIOException;
 import org.apache.hadoop.hbase.ExtendedCell;
 import org.apache.hadoop.hbase.KeyValue;
 import org.apache.hadoop.hbase.KeyValueUtil;
@@ -396,12 +397,15 @@ public class DefaultMobStoreCompactor extends 
DefaultCompactor {
               // Added to support migration
               try {
                 mobCell = resolveMobCell(c);
-              } catch (FileNotFoundException fnfe) {
-                if (discardMobMiss) {
+              } catch (DoNotRetryIOException e) {
+                if (
+                  discardMobMiss && e.getCause() != null
+                    && e.getCause() instanceof FileNotFoundException
+                ) {
                   LOG.error("Missing MOB cell: file={} not found cell={}", 
fName, c);
                   continue;
                 } else {
-                  throw fnfe;
+                  throw e;
                 }
               }
 
diff --git 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
 
b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
index aa4c2c38c19..9186a64ea97 100644
--- 
a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
+++ 
b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
@@ -29,6 +29,7 @@ import java.util.concurrent.atomic.AtomicLong;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.DoNotRetryIOException;
 import org.apache.hadoop.hbase.ExtendedCell;
 import org.apache.hadoop.hbase.KeyValue;
 import org.apache.hadoop.hbase.PrivateCellUtil;
@@ -193,12 +194,15 @@ public class FaultyMobStoreCompactor extends 
DefaultMobStoreCompactor {
               // Added to support migration
               try {
                 mobCell = resolveMobCell(c);
-              } catch (FileNotFoundException fnfe) {
-                if (discardMobMiss) {
-                  LOG.error("Missing MOB cell: file={} not found", fName);
+              } catch (DoNotRetryIOException e) {
+                if (
+                  discardMobMiss && e.getCause() != null
+                    && e.getCause() instanceof FileNotFoundException
+                ) {
+                  LOG.error("Missing MOB cell: file={} not found cell={}", 
fName, c);
                   continue;
                 } else {
-                  throw fnfe;
+                  throw e;
                 }
               }
 

Reply via email to