HBASE-11994 PutCombiner floods the M/R log with repeated log messages (Aditya Kishore)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/ddd44ecb Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/ddd44ecb Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/ddd44ecb Branch: refs/heads/branch-1 Commit: ddd44ecb66bee60570b71fd80b4b0187c5441966 Parents: 757a095 Author: Andrew Purtell <[email protected]> Authored: Tue Sep 16 13:55:14 2014 -0700 Committer: Andrew Purtell <[email protected]> Committed: Tue Sep 16 13:55:25 2014 -0700 ---------------------------------------------------------------------- .../java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/ddd44ecb/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java index f10836b..a7f0f6f 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/PutCombiner.java @@ -80,15 +80,20 @@ public class PutCombiner<K> extends Reducer<K, Put, K, Put> { } if (cnt % 10 == 0) context.setStatus("Combine " + cnt); if (curSize > threshold) { - LOG.info(String.format("Combined %d Put(s) into %d.", cnt, 1)); + if (LOG.isDebugEnabled()) { + LOG.debug(String.format("Combined %d Put(s) into %d.", cnt, 1)); + } context.write(row, put); put = null; + curSize = 0; cnt = 0; } } } if (put != null) { - LOG.info(String.format("Combined %d Put(s) into %d.", cnt, 1)); + if (LOG.isDebugEnabled()) { + LOG.debug(String.format("Combined %d Put(s) into %d.", cnt, 1)); + } context.write(row, put); } }
