Repository: hbase Updated Branches: refs/heads/branch-1 660f909a5 -> 1dd703070
HBASE-12165 TestEndToEndSplitTransaction.testFromClientSideWhileSplitting fails -- DEBUGGING STRINGS Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1dd70307 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1dd70307 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1dd70307 Branch: refs/heads/branch-1 Commit: 1dd70307018f9c259b42289ca615ac2d50c30565 Parents: 660f909 Author: stack <[email protected]> Authored: Thu Oct 2 21:10:45 2014 -0700 Committer: stack <[email protected]> Committed: Thu Oct 2 21:12:17 2014 -0700 ---------------------------------------------------------------------- .../TestEndToEndSplitTransaction.java | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/1dd70307/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java index bca4fee..7dfdd1d 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java @@ -251,7 +251,7 @@ public class TestEndToEndSplitTransaction { public void run() { try { Random random = new Random(); - for (int i=0; i< 5; i++) { + for (int i= 0; i< 5; i++) { NavigableMap<HRegionInfo, ServerName> regions = MetaScanner.allTableRegions(conf, null, tableName, false); if (regions.size() == 0) { @@ -357,7 +357,7 @@ public class TestEndToEndSplitTransaction { } void verifyTableRegions(Set<HRegionInfo> regions) { - log("Verifying " + regions.size() + " regions"); + log("Verifying " + regions.size() + " regions: " + regions); byte[][] startKeys = new byte[regions.size()][]; byte[][] endKeys = new byte[regions.size()][]; @@ -444,14 +444,16 @@ public class TestEndToEndSplitTransaction { Table metaTable = new HTable(conf, TableName.META_TABLE_NAME); try { - while (System.currentTimeMillis() - start < timeout) { - Result result = getRegionRow(metaTable, regionName); + Result result = null; + HRegionInfo region = null; + while ((System.currentTimeMillis() - start) < timeout) { + result = getRegionRow(metaTable, regionName); if (result == null) { break; } - HRegionInfo region = HRegionInfo.getHRegionInfo(result); - if(region.isSplitParent()) { + region = HRegionInfo.getHRegionInfo(result); + if (region.isSplitParent()) { log("found parent region: " + region.toString()); PairOfSameType<HRegionInfo> pair = HRegionInfo.getDaughterRegions(result); daughterA = pair.getFirst(); @@ -460,6 +462,11 @@ public class TestEndToEndSplitTransaction { } Threads.sleep(100); } + if (daughterA == null || daughterB == null) { + throw new IOException("Failed to get daughters, daughterA=" + daughterA + ", daughterB=" + + daughterB + ", timeout=" + timeout + ", result=" + result + ", regionName=" + regionName + + ", region=" + region); + } //if we are here, this means the region split is complete or timed out if (waitForDaughters) {
