Repository: hbase Updated Branches: refs/heads/branch-1.0 8d35d729a -> d92fcdd62
HBASE-13342 Fix incorrect interface annotations Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d92fcdd6 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d92fcdd6 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d92fcdd6 Branch: refs/heads/branch-1.0 Commit: d92fcdd62029056be2505821b760c4d899068f3e Parents: 8d35d72 Author: Elliott Clark <ecl...@apache.org> Authored: Thu Mar 26 11:48:19 2015 -0700 Committer: Elliott Clark <ecl...@apache.org> Committed: Fri Mar 27 00:26:26 2015 -0700 ---------------------------------------------------------------------- dev-support/test-patch.sh | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/d92fcdd6/dev-support/test-patch.sh ---------------------------------------------------------------------- diff --git a/dev-support/test-patch.sh b/dev-support/test-patch.sh index 3c01359..cd46401 100755 --- a/dev-support/test-patch.sh +++ b/dev-support/test-patch.sh @@ -421,6 +421,29 @@ checkAntiPatterns () { } ############################################################################### +### Check that there are no incorrect annotations +checkInterfaceAudience () { + echo "" + echo "" + echo "======================================================================" + echo "======================================================================" + echo " Checking against hadoop InterfaceAudience." + echo "======================================================================" + echo "======================================================================" + echo "" + echo "" + warnings=`$GREP 'import org.apache.hadoop.classification' $PATCH_DIR/patch` + if [[ $warnings != "" ]]; then + JIRA_COMMENT="$JIRA_COMMENT + + {color:red}-1 InterfaceAudience{color}. The patch appears to contain InterfaceAudience from hadoop rather than hbase: + $warnings." + return 1 + fi + return 0 +} + +############################################################################### ### Check there are no javadoc warnings checkJavadocWarnings () { echo "" @@ -909,6 +932,8 @@ checkJavadocWarnings (( RESULT = RESULT + $? )) checkCheckstyleErrors (( RESULT = RESULT + $? )) +checkInterfaceAudience +(( RESULT = RESULT + $? )) checkFindbugsWarnings (( RESULT = RESULT + $? )) checkReleaseAuditWarnings
