Repository: hbase Updated Branches: refs/heads/branch-1.1 d0fd2cb35 -> 20ddb622c
HBASE-13552 ChoreService shutdown message could be more informative (Jonathan Lawlor) Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/20ddb622 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/20ddb622 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/20ddb622 Branch: refs/heads/branch-1.1 Commit: 20ddb622c55e1d4f80fe571676077e5b2105ce98 Parents: d0fd2cb Author: stack <[email protected]> Authored: Fri Apr 24 13:42:03 2015 -0700 Committer: stack <[email protected]> Committed: Fri Apr 24 13:43:29 2015 -0700 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/hbase/ChoreService.java | 6 +++--- .../src/main/java/org/apache/hadoop/hbase/ScheduledChore.java | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/20ddb622/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java ---------------------------------------------------------------------- diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java index 5e2e43e..17c75f8 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java @@ -21,7 +21,6 @@ package org.apache.hadoop.hbase; import java.util.ArrayList; import java.util.HashMap; import java.util.LinkedHashMap; -import java.util.List; import java.util.Map.Entry; import java.util.concurrent.ScheduledFuture; import java.util.concurrent.ScheduledThreadPoolExecutor; @@ -298,9 +297,10 @@ public class ChoreService implements ChoreServicer { * after this method has been called (i.e. future scheduling attempts will fail). */ public void shutdown() { - List<Runnable> ongoing = scheduler.shutdownNow(); + scheduler.shutdownNow(); if (LOG.isInfoEnabled()) { - LOG.info("Chore service for: " + coreThreadPoolPrefix + " had " + ongoing + " on shutdown"); + LOG.info("Chore service for: " + coreThreadPoolPrefix + " had " + scheduledChores.keySet() + + " on shutdown"); } cancelAllChores(true); scheduledChores.clear(); http://git-wip-us.apache.org/repos/asf/hbase/blob/20ddb622/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java ---------------------------------------------------------------------- diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java index 16d080b..8670d60 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java @@ -338,4 +338,10 @@ public abstract class ScheduledChore implements Runnable { */ protected synchronized void cleanup() { } + + @Override + public String toString() { + return "[ScheduledChore: Name: " + getName() + " Period: " + getPeriod() + " Unit: " + + getTimeUnit() + "]"; + } }
