Repository: hbase Updated Branches: refs/heads/master 84dd84fc5 -> 94a00bea0
http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java index 6abe076..d606495 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java @@ -182,7 +182,7 @@ import com.google.protobuf.ByteString; public class TestHRegion { // Do not spin up clusters in here. If you need to spin up a cluster, do it // over in TestHRegionOnCluster. - static final Log LOG = LogFactory.getLog(TestHRegion.class); + private static final Log LOG = LogFactory.getLog(TestHRegion.class); @Rule public TestName name = new TestName(); private static final String COLUMN_FAMILY = "MyCF"; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java index 9c9cfdc..70ae657 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java @@ -101,7 +101,7 @@ import com.google.protobuf.ByteString; @Category(MediumTests.class) public class TestHRegionReplayEvents { - static final Log LOG = LogFactory.getLog(TestHRegion.class); + private static final Log LOG = LogFactory.getLog(TestHRegion.class); @Rule public TestName name = new TestName(); private static HBaseTestingUtility TEST_UTIL; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java index af49556..22e91f0 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java @@ -80,7 +80,7 @@ import static org.junit.Assert.assertThat; */ @Category({RegionServerTests.class, LargeTests.class}) public class TestHRegionServerBulkLoad { - final static Log LOG = LogFactory.getLog(TestHRegionServerBulkLoad.class); + private static final Log LOG = LogFactory.getLog(TestHRegionServerBulkLoad.class); private static HBaseTestingUtility UTIL = new HBaseTestingUtility(); private final static Configuration conf = UTIL.getConfiguration(); private final static byte[] QUAL = Bytes.toBytes("qual"); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java index 81d681c..1fe57d0 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java @@ -57,7 +57,7 @@ import org.junit.experimental.categories.Category; */ @Category({RegionServerTests.class, LargeTests.class}) public class TestJoinedScanners { - static final Log LOG = LogFactory.getLog(TestJoinedScanners.class); + private static final Log LOG = LogFactory.getLog(TestJoinedScanners.class); private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private static final String DIR = TEST_UTIL.getDataTestDir("TestJoinedScanners").toString(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java index cc16804..a466c4d 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMajorCompaction.java @@ -73,7 +73,7 @@ import org.junit.rules.TestName; @Category({RegionServerTests.class, MediumTests.class}) public class TestMajorCompaction { @Rule public TestName name = new TestName(); - static final Log LOG = LogFactory.getLog(TestMajorCompaction.class.getName()); + private static final Log LOG = LogFactory.getLog(TestMajorCompaction.class.getName()); private static final HBaseTestingUtility UTIL = HBaseTestingUtility.createLocalHTU(); protected Configuration conf = UTIL.getConfiguration(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompaction.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompaction.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompaction.java index b694fe2..2504d9c 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompaction.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompaction.java @@ -53,7 +53,7 @@ import org.junit.rules.TestName; @Category({RegionServerTests.class, MediumTests.class}) public class TestMinorCompaction { @Rule public TestName name = new TestName(); - static final Log LOG = LogFactory.getLog(TestMinorCompaction.class.getName()); + private static final Log LOG = LogFactory.getLog(TestMinorCompaction.class.getName()); private static final HBaseTestingUtility UTIL = HBaseTestingUtility.createLocalHTU(); protected Configuration conf = UTIL.getConfiguration(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java index ea668b0..d9453b0 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestParallelPut.java @@ -57,7 +57,7 @@ import org.junit.rules.TestName; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestParallelPut { - static final Log LOG = LogFactory.getLog(TestParallelPut.class); + private static final Log LOG = LogFactory.getLog(TestParallelPut.class); @Rule public TestName name = new TestName(); private HRegion region = null; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java index 84cb355..cdef351 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java @@ -68,7 +68,7 @@ import org.junit.rules.TestName; @Category({RegionServerTests.class, SmallTests.class}) public class TestScanner { @Rule public TestName name = new TestName(); - private final Log LOG = LogFactory.getLog(this.getClass()); + private static final Log LOG = LogFactory.getLog(TestScanner.class); private final static HBaseTestingUtility TEST_UTIL = HBaseTestingUtility.createLocalHTU(); private static final byte [] FIRST_ROW = HConstants.EMPTY_START_ROW; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java index 50545c9..df73ddd 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java @@ -75,7 +75,7 @@ import com.google.protobuf.ServiceException; */ @Category(MediumTests.class) public class TestScannerHeartbeatMessages { - final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog(TestScannerHeartbeatMessages.class); private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java index 59793e0..be18dd4 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java @@ -97,7 +97,7 @@ import com.google.common.collect.Lists; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestStore { - public static final Log LOG = LogFactory.getLog(TestStore.class); + private static final Log LOG = LogFactory.getLog(TestStore.class); @Rule public TestName name = new TestName(); HStore store; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java index e5a5022..e8eb13d 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java @@ -73,7 +73,7 @@ import com.google.common.collect.Lists; */ @Category({RegionServerTests.class, SmallTests.class}) public class TestStoreFile extends HBaseTestCase { - static final Log LOG = LogFactory.getLog(TestStoreFile.class); + private static final Log LOG = LogFactory.getLog(TestStoreFile.class); private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private CacheConfig cacheConf = new CacheConfig(TEST_UTIL.getConfiguration()); private static String ROOT_DIR = TEST_UTIL.getDataTestDir("TestStoreFile").toString(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java index fb4561b..cfa1695 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java @@ -45,7 +45,7 @@ import org.junit.experimental.categories.Category; @Category({RegionServerTests.class, SmallTests.class}) public class TestWideScanner extends HBaseTestCase { - private final Log LOG = LogFactory.getLog(this.getClass()); + private static final Log LOG = LogFactory.getLog(TestWideScanner.class); static final byte[] A = Bytes.toBytes("A"); static final byte[] B = Bytes.toBytes("B"); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java index 7c13c00..6ebafc9 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java @@ -53,7 +53,7 @@ import org.apache.hadoop.io.compress.DefaultCodec; */ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG) public class SequenceFileLogWriter extends WriterBase { - private final Log LOG = LogFactory.getLog(this.getClass()); + private static final Log LOG = LogFactory.getLog(SequenceFileLogWriter.class); // The sequence file we delegate to. private SequenceFile.Writer writer; // This is the FSDataOutputStream instance that is the 'out' instance http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java index 77071ce..7d76117 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java @@ -82,7 +82,7 @@ import org.junit.rules.TestName; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestFSHLog { - protected static final Log LOG = LogFactory.getLog(TestFSHLog.class); + private static final Log LOG = LogFactory.getLog(TestFSHLog.class); protected static Configuration conf; protected static FileSystem fs; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestProtobufLog.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestProtobufLog.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestProtobufLog.java index 04cb2ce..c1df225 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestProtobufLog.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestProtobufLog.java @@ -62,7 +62,7 @@ import org.junit.rules.TestName; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestProtobufLog { - protected static final Log LOG = LogFactory.getLog(TestProtobufLog.class); + private static final Log LOG = LogFactory.getLog(TestProtobufLog.class); protected final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java index 25c83a8..2c00b33 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java @@ -48,7 +48,7 @@ import static org.junit.Assert.*; */ @Category({RegionServerTests.class, SmallTests.class}) public class TestWALActionsListener { - protected static final Log LOG = LogFactory.getLog(TestWALActionsListener.class); + private static final Log LOG = LogFactory.getLog(TestWALActionsListener.class); private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java index 5310a2e..64e81fa 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java @@ -105,7 +105,7 @@ import org.mockito.Mockito; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestWALReplay { - public static final Log LOG = LogFactory.getLog(TestWALReplay.class); + private static final Log LOG = LogFactory.getLog(TestWALReplay.class); static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private final EnvironmentEdge ee = EnvironmentEdgeManager.getDelegate(); private Path hbaseRootDir = null; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java index 633dcc9..451c39f 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java @@ -54,7 +54,7 @@ import org.junit.experimental.categories.Category; */ @Category({ReplicationTests.class, MediumTests.class}) public class TestReplicationEndpoint extends TestReplicationBase { - static final Log LOG = LogFactory.getLog(TestReplicationEndpoint.class); + private static final Log LOG = LogFactory.getLog(TestReplicationEndpoint.class); static int numRegionServers; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java index f85832e..02b7f9a 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java @@ -41,7 +41,7 @@ import com.google.common.collect.ImmutableSet; @Category({SecurityTests.class, SmallTests.class}) public class TestUser { - private static Log LOG = LogFactory.getLog(TestUser.class); + private static final Log LOG = LogFactory.getLog(TestUser.class); @Test public void testBasicAttributes() throws Exception { http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java index 6bb2765..c83e502 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java @@ -101,7 +101,7 @@ public class TestTokenAuthentication { System.setProperty("java.security.krb5.realm", "hbase"); System.setProperty("java.security.krb5.kdc", "blah"); } - private static Log LOG = LogFactory.getLog(TestTokenAuthentication.class); + private static final Log LOG = LogFactory.getLog(TestTokenAuthentication.class); public interface AuthenticationServiceSecurityInfo {} @@ -110,7 +110,7 @@ public class TestTokenAuthentication { */ private static class TokenServer extends TokenProvider implements AuthenticationProtos.AuthenticationService.BlockingInterface, Runnable, Server { - private static Log LOG = LogFactory.getLog(TokenServer.class); + private static final Log LOG = LogFactory.getLog(TokenServer.class); private Configuration conf; private RpcServerInterface rpcServer; private InetSocketAddress isa; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcher.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcher.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcher.java index 9552ad3..857cdd0 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcher.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcher.java @@ -47,7 +47,7 @@ import org.junit.experimental.categories.Category; */ @Category({SecurityTests.class, LargeTests.class}) public class TestZKSecretWatcher { - private static Log LOG = LogFactory.getLog(TestZKSecretWatcher.class); + private static final Log LOG = LogFactory.getLog(TestZKSecretWatcher.class); private static HBaseTestingUtility TEST_UTIL; private static AuthenticationTokenSecretManager KEY_MASTER; private static AuthenticationTokenSecretManagerForTest KEY_SLAVE; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java index 3297002..b7a6240 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java @@ -56,7 +56,8 @@ import com.google.protobuf.ByteString; @Category({SecurityTests.class, MediumTests.class}) public class TestVisibilityLabelsWithDefaultVisLabelService extends TestVisibilityLabels { - final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog( + TestVisibilityLabelsWithDefaultVisLabelService.class); @BeforeClass public static void setupBeforeClass() throws Exception { http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java index 2774bee..71a39f0 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java @@ -64,7 +64,7 @@ import org.junit.experimental.categories.Category; */ @Category({VerySlowRegionServerTests.class, MediumTests.class}) public class TestExportSnapshot { - private final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog(TestExportSnapshot.class); protected final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java index ae1ca13..219e694 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java @@ -49,7 +49,7 @@ import org.junit.experimental.categories.Category; */ @Category({RegionServerTests.class, LargeTests.class}) public class TestRestoreFlushSnapshotFromClient { - final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog(TestRestoreFlushSnapshotFromClient.class); private final static HBaseTestingUtility UTIL = new HBaseTestingUtility(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java index 7309580..3fac2fd 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreSnapshotHelper.java @@ -51,7 +51,7 @@ import org.mockito.Mockito; */ @Category({RegionServerTests.class, SmallTests.class}) public class TestRestoreSnapshotHelper { - final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog(TestRestoreSnapshotHelper.class); private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private final static String TEST_HFILE = "abc"; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MockServer.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MockServer.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MockServer.java index 9f2b0b8..1fcfcbb 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MockServer.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/MockServer.java @@ -36,7 +36,7 @@ import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher; * Basic mock Server for handler tests. */ public class MockServer implements Server { - static final Log LOG = LogFactory.getLog(MockServer.class); + private static final Log LOG = LogFactory.getLog(MockServer.class); final static ServerName NAME = ServerName.valueOf("MockServer", 123, -1); boolean stopped; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java index c5bd284..43c7cfc 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java @@ -41,7 +41,7 @@ import static org.junit.Assert.*; @Category({MiscTests.class, SmallTests.class}) public class TestCompressionTest { - static final Log LOG = LogFactory.getLog(TestCompressionTest.class); + private static final Log LOG = LogFactory.getLog(TestCompressionTest.class); @Test public void testExceptionCaching() { http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java index 7600388..866382d 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java @@ -74,7 +74,7 @@ import org.junit.runners.Parameterized.Parameters; @Category({MiscTests.class, MediumTests.class}) @RunWith(Parameterized.class) public class TestCoprocessorScanPolicy { - final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog(TestCoprocessorScanPolicy.class); protected final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private static final byte[] F = Bytes.toBytes("fam"); private static final byte[] Q = Bytes.toBytes("qual"); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSVisitor.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSVisitor.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSVisitor.java index d1516ca..142e46e 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSVisitor.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSVisitor.java @@ -43,7 +43,7 @@ import org.junit.experimental.categories.Category; */ @Category({MiscTests.class, MediumTests.class}) public class TestFSVisitor { - final Log LOG = LogFactory.getLog(getClass()); + private static final Log LOG = LogFactory.getLog(TestFSVisitor.class); private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java index 4a741a9..17dab15 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java @@ -132,8 +132,7 @@ import com.google.common.collect.Multimap; @Category({MiscTests.class, LargeTests.class}) public class TestHBaseFsck { static final int POOL_SIZE = 7; - - final static Log LOG = LogFactory.getLog(TestHBaseFsck.class); + private static final Log LOG = LogFactory.getLog(TestHBaseFsck.class); private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private final static Configuration conf = TEST_UTIL.getConfiguration(); private final static String FAM_STR = "fam"; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java index 056eeb2..6400186 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java @@ -54,7 +54,7 @@ import org.junit.experimental.categories.Category; /** Test stand alone merge tool that can merge arbitrary regions */ @Category({MiscTests.class, LargeTests.class}) public class TestMergeTool extends HBaseTestCase { - static final Log LOG = LogFactory.getLog(TestMergeTool.class); + private static final Log LOG = LogFactory.getLog(TestMergeTool.class); HBaseTestingUtility TEST_UTIL; // static final byte [] COLUMN_NAME = Bytes.toBytes("contents:"); static final byte [] FAMILY = Bytes.toBytes("contents"); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java index e940425..f7f1f43 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java @@ -75,7 +75,7 @@ import org.junit.experimental.categories.Category; */ @Category({MiscTests.class, LargeTests.class}) public class OfflineMetaRebuildTestCore { - protected final static Log LOG = LogFactory + private final static Log LOG = LogFactory .getLog(OfflineMetaRebuildTestCore.class); protected HBaseTestingUtility TEST_UTIL; protected Configuration conf; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java index d4f86e9..17a208f 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java @@ -25,6 +25,8 @@ import static org.junit.Assert.assertTrue; import java.util.Arrays; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.HTableDescriptor; import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.client.Admin; @@ -41,6 +43,7 @@ import org.junit.experimental.categories.Category; */ @Category({MiscTests.class, MediumTests.class}) public class TestOfflineMetaRebuildBase extends OfflineMetaRebuildTestCore { + private static final Log LOG = LogFactory.getLog(TestOfflineMetaRebuildBase.class); @SuppressWarnings("deprecation") @Test(timeout = 120000) @@ -94,4 +97,4 @@ public class TestOfflineMetaRebuildBase extends OfflineMetaRebuildTestCore { LOG.info("Table " + table + " has " + tableRowCount(conf, table) + " entries."); assertEquals(16, tableRowCount(conf, table)); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java index 6320b93..615487d 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java @@ -24,6 +24,8 @@ import static org.junit.Assert.assertFalse; import java.util.Arrays; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.HTableDescriptor; import org.apache.hadoop.hbase.testclassification.MediumTests; import org.apache.hadoop.hbase.testclassification.MiscTests; @@ -38,6 +40,7 @@ import org.junit.experimental.categories.Category; */ @Category({MiscTests.class, MediumTests.class}) public class TestOfflineMetaRebuildHole extends OfflineMetaRebuildTestCore { + private final static Log LOG = LogFactory.getLog(TestOfflineMetaRebuildHole.class); @Test(timeout = 120000) public void testMetaRebuildHoleFail() throws Exception { @@ -95,4 +98,4 @@ public class TestOfflineMetaRebuildHole extends OfflineMetaRebuildTestCore { ERROR_CODE.NOT_IN_META_OR_DEPLOYED, ERROR_CODE.NOT_IN_META_OR_DEPLOYED}); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java index e49b154..40ba86a 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java @@ -24,6 +24,8 @@ import static org.junit.Assert.assertFalse; import java.util.Arrays; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.apache.hadoop.hbase.HTableDescriptor; import org.apache.hadoop.hbase.testclassification.MediumTests; import org.apache.hadoop.hbase.testclassification.MiscTests; @@ -41,6 +43,7 @@ import com.google.common.collect.Multimap; */ @Category({MiscTests.class, MediumTests.class}) public class TestOfflineMetaRebuildOverlap extends OfflineMetaRebuildTestCore { + private final static Log LOG = LogFactory.getLog(TestOfflineMetaRebuildOverlap.class); @Test(timeout = 120000) public void testMetaRebuildOverlapFail() throws Exception { @@ -105,4 +108,4 @@ public class TestOfflineMetaRebuildOverlap extends OfflineMetaRebuildTestCore { ERROR_CODE.NOT_IN_META_OR_DEPLOYED, ERROR_CODE.NOT_IN_META_OR_DEPLOYED}); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDefaultWALProvider.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDefaultWALProvider.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDefaultWALProvider.java index df8ceaf..cf0488a 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDefaultWALProvider.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDefaultWALProvider.java @@ -61,7 +61,7 @@ import org.apache.hadoop.hbase.regionserver.wal.WALEdit; @Category({RegionServerTests.class, MediumTests.class}) public class TestDefaultWALProvider { - protected static final Log LOG = LogFactory.getLog(TestDefaultWALProvider.class); + private static final Log LOG = LogFactory.getLog(TestDefaultWALProvider.class); protected static Configuration conf; protected static FileSystem fs; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSecureWAL.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSecureWAL.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSecureWAL.java index 6f05839..6ae8ee1 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSecureWAL.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSecureWAL.java @@ -58,7 +58,7 @@ import org.junit.experimental.categories.Category; @Category({RegionServerTests.class, MediumTests.class}) public class TestSecureWAL { - static final Log LOG = LogFactory.getLog(TestSecureWAL.class); + private static final Log LOG = LogFactory.getLog(TestSecureWAL.class); static { ((Log4JLogger)LogFactory.getLog("org.apache.hadoop.hbase.regionserver.wal")) .getLogger().setLevel(Level.ALL); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java index bbe4018..fdc8e45 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java @@ -81,7 +81,7 @@ import org.apache.hadoop.hbase.regionserver.wal.WALEdit; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestWALFactory { - protected static final Log LOG = LogFactory.getLog(TestWALFactory.class); + private static final Log LOG = LogFactory.getLog(TestWALFactory.class); protected static Configuration conf; private static MiniDFSCluster cluster; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java index deaef50..52e28eb 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java @@ -67,7 +67,7 @@ import org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec; */ @Category({RegionServerTests.class, MediumTests.class}) public class TestWALReaderOnSecureWAL { - static final Log LOG = LogFactory.getLog(TestWALReaderOnSecureWAL.class); + private static final Log LOG = LogFactory.getLog(TestWALReaderOnSecureWAL.class); static { ((Log4JLogger)LogFactory.getLog("org.apache.hadoop.hbase.regionserver.wal")) .getLogger().setLevel(Level.ALL); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java index 05d5e51..7d4a0f8 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java @@ -83,7 +83,7 @@ import org.apache.hadoop.hbase.regionserver.wal.WALEdit; */ @InterfaceAudience.Private public final class WALPerformanceEvaluation extends Configured implements Tool { - static final Log LOG = LogFactory.getLog(WALPerformanceEvaluation.class.getName()); + private static final Log LOG = LogFactory.getLog(WALPerformanceEvaluation.class.getName()); private final MetricsRegistry metrics = new MetricsRegistry(); private final Meter syncMeter = metrics.newMeter(WALPerformanceEvaluation.class, "syncMeter", "syncs", TimeUnit.MILLISECONDS); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java index c830b04..1faf8e5 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java @@ -38,7 +38,7 @@ import org.junit.experimental.categories.Category; */ @Category({MiscTests.class, MediumTests.class}) public class TestZKLeaderManager { - private static Log LOG = LogFactory.getLog(TestZKLeaderManager.class); + private static final Log LOG = LogFactory.getLog(TestZKLeaderManager.class); private static final String LEADER_ZNODE = "/test/" + TestZKLeaderManager.class.getSimpleName(); http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java index e609a71..59e5856 100644 --- a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java +++ b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java @@ -35,7 +35,7 @@ import org.apache.hadoop.hbase.classification.InterfaceAudience; */ @InterfaceAudience.Private public class CallQueue implements BlockingQueue<Runnable> { - private static Log LOG = LogFactory.getLog(CallQueue.class); + private static final Log LOG = LogFactory.getLog(CallQueue.class); private final BlockingQueue<Call> underlyingQueue; private final ThriftMetrics metrics; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java index b5498ba..51a0444 100644 --- a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java +++ b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java @@ -37,7 +37,7 @@ import org.apache.hadoop.hbase.thrift.generated.Hbase; @InterfaceAudience.Private public class HbaseHandlerMetricsProxy implements InvocationHandler { - public static final Log LOG = LogFactory.getLog( + private static final Log LOG = LogFactory.getLog( HbaseHandlerMetricsProxy.class); private final Hbase.Iface handler; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java index bdbe445..13a2e50 100644 --- a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java +++ b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java @@ -161,7 +161,7 @@ public class IncrementCoalescer implements IncrementCoalescerMBean { private int maxQueueSize = 500000; private static final int CORE_POOL_SIZE = 1; - protected final Log LOG = LogFactory.getLog(this.getClass().getName()); + private static final Log LOG = LogFactory.getLog(FullyQualifiedRow.class); @SuppressWarnings("deprecation") public IncrementCoalescer(HBaseHandler hand) { http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java index c7ea46f..28aa0e1 100644 --- a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java +++ b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java @@ -51,7 +51,7 @@ import org.ietf.jgss.Oid; @InterfaceAudience.Private public class ThriftHttpServlet extends TServlet { private static final long serialVersionUID = 1L; - public static final Log LOG = LogFactory.getLog(ThriftHttpServlet.class.getName()); + private static final Log LOG = LogFactory.getLog(ThriftHttpServlet.class.getName()); private transient final UserGroupInformation realUser; private transient final Configuration conf; private final boolean securityEnabled; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java index 4e4ade3..daf320c 100644 --- a/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java +++ b/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java @@ -631,7 +631,7 @@ public class ThriftServerRunner implements Runnable { */ public static class HBaseHandler implements Hbase.Iface { protected Configuration conf; - protected final Log LOG = LogFactory.getLog(this.getClass().getName()); + protected static final Log LOG = LogFactory.getLog(HBaseHandler.class); // nextScannerId and scannerMap are used to manage scanner state protected int nextScannerId = 0; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java index 189f17e..b646009 100644 --- a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java +++ b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java @@ -45,7 +45,7 @@ import org.junit.Test; @RunWith(Parameterized.class) public class TestCallQueue { - public static final Log LOG = LogFactory.getLog(TestCallQueue.class); + private static final Log LOG = LogFactory.getLog(TestCallQueue.class); private static final HBaseTestingUtility UTIL = new HBaseTestingUtility(); private static final MetricsAssertHelper metricsHelper = http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java index 9341ffa..f105f3d 100644 --- a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java +++ b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java @@ -49,7 +49,7 @@ import com.google.common.base.Joiner; public class TestThriftHttpServer { - public static final Log LOG = + private static final Log LOG = LogFactory.getLog(TestThriftHttpServer.class); private static final HBaseTestingUtility TEST_UTIL = http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java index 9446d2f..82d5bb1 100644 --- a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java +++ b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java @@ -61,7 +61,7 @@ import com.google.common.base.Joiner; @RunWith(Parameterized.class) public class TestThriftServerCmdLine { - public static final Log LOG = + private static final Log LOG = LogFactory.getLog(TestThriftServerCmdLine.class); private final ImplType implType; http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java index f4df271..5b7a808 100644 --- a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java +++ b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java @@ -89,7 +89,7 @@ import static java.nio.ByteBuffer.wrap; @Category({ClientTests.class, MediumTests.class}) public class TestThriftHBaseServiceHandler { - public static final Log LOG = LogFactory.getLog(TestThriftHBaseServiceHandler.class); + private static final Log LOG = LogFactory.getLog(TestThriftHBaseServiceHandler.class); private static final HBaseTestingUtility UTIL = new HBaseTestingUtility(); // Static names for tables, columns, rows, and values http://git-wip-us.apache.org/repos/asf/hbase/blob/94a00bea/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java ---------------------------------------------------------------------- diff --git a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java index 42d1b08..6c80907 100644 --- a/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java +++ b/hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java @@ -74,7 +74,7 @@ import org.junit.experimental.categories.Category; @Category({ClientTests.class, MediumTests.class}) public class TestThriftHBaseServiceHandlerWithLabels { -public static final Log LOG = LogFactory + private static final Log LOG = LogFactory .getLog(TestThriftHBaseServiceHandlerWithLabels.class); private static final HBaseTestingUtility UTIL = new HBaseTestingUtility();
