HBASE-14407 NotServingRegion: hbase region closed forever (Shuaifeng Zhou)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/eb4b143b Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/eb4b143b Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/eb4b143b Branch: refs/heads/0.98 Commit: eb4b143b95400b359006a2d4e7c092f0617bb45a Parents: 9e1cd30 Author: Andrew Purtell <[email protected]> Authored: Fri Sep 25 17:57:28 2015 -0700 Committer: Andrew Purtell <[email protected]> Committed: Fri Sep 25 17:57:28 2015 -0700 ---------------------------------------------------------------------- .../hadoop/hbase/master/AssignmentManager.java | 28 +++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/eb4b143b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java index ff90f50..e7ce1a7 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java @@ -2299,7 +2299,33 @@ public class AssignmentManager extends ZooKeeperListener { LOG.debug("ALREADY_OPENED " + region.getRegionNameAsString() + " to " + sn); String encodedName = region.getEncodedName(); - deleteNodeInStates(encodedName, "offline", sn, EventType.M_ZK_REGION_OFFLINE); + + //If use ZkForAssignment, region already Opened event should not be handled, + //leave it to zk event. See HBase-14407. + if(useZKForAssignment){ + String node = ZKAssign.getNodeName(watcher, encodedName); + Stat stat = new Stat(); + try { + byte[] existingBytes = ZKUtil.getDataNoWatch(watcher, node, stat); + if(existingBytes!=null){ + RegionTransition rt= RegionTransition.parseFrom(existingBytes); + EventType et = rt.getEventType(); + if (et.equals(EventType.RS_ZK_REGION_OPENED)) { + LOG.debug("ALREADY_OPENED " + region.getRegionNameAsString() + + " and node in "+et+" state"); + return; + } + } + } catch (KeeperException ke) { + LOG.warn("Unexpected ZK exception getData " + node + + " node for the region " + encodedName, ke); + } catch (DeserializationException e) { + LOG.warn("Get RegionTransition from zk deserialization failed! ", e); + } + + deleteNodeInStates(encodedName, "offline", sn, EventType.M_ZK_REGION_OFFLINE); + } + regionStates.regionOnline(region, sn); }
